Skip to content

chore: allow argo-cd >=3 <=3.2 #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: allow argo-cd >=3 <=3.2 #935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/gitops-runtime/templates/hooks/pre-install/_env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ NAMESPACE:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
REQUIRED_VERSION_CONSTRAINT: ">=2.12 <3.1"
REQUIRED_VERSION_CONSTRAINT: ">=3 <=3.2"
Copy link
Contributor

@dmaizel dmaizel Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this will work for all runtime versions between 3.0 and 3.3 (excluding 3.3) ?

Copy link
Contributor Author

@ATGardner ATGardner Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test it out with https://jubianchi.github.io/semver-check/#/%3E%3D3%20%3C%3D3.2/3.2.9
i think it is correct, yeah

Copy link
Contributor Author

@ATGardner ATGardner Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but >=3 <3.3 would work just as well, if you think it is more clear

{{- end -}}

{{- define "installer.validate-values.environment-variables" -}}
Expand Down