chore: allow argo-cd >=3 <=3.2
#935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the REQUIRED_VERSION_CONSTRAINT to ensure compatibility with Argo CD versions 3.0 to 3.2, allowing for smoother upgrades and installation processes.
dmaizel
reviewed
Nov 18, 2025
| fieldRef: | ||
| fieldPath: metadata.namespace | ||
| REQUIRED_VERSION_CONSTRAINT: ">=2.12 <3.1" | ||
| REQUIRED_VERSION_CONSTRAINT: ">=3 <=3.2" |
Contributor
There was a problem hiding this comment.
Are you sure this will work for all runtime versions between 3.0 and 3.3 (excluding 3.3) ?
Contributor
Author
There was a problem hiding this comment.
test it out with https://jubianchi.github.io/semver-check/#/%3E%3D3%20%3C%3D3.2/3.2.9
i think it is correct, yeah
Contributor
Author
There was a problem hiding this comment.
but >=3 <3.3 would work just as well, if you think it is more clear
dmaizel
approved these changes
Nov 18, 2025
Contributor
Author
|
re-created in #937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adjust the REQUIRED_VERSION_CONSTRAINT to ensure compatibility with
Argo CD versions 3.0 to 3.2, allowing for smoother upgrades and
installation processes.