Skip to content

⚡️ Speed up function cividis by 23% #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up function cividis by 23% #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/bokeh/palettes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,7 +1526,13 @@ def linear_palette(palette: Palette, n: int) -> Palette:
"""
if n > len(palette):
raise ValueError(f"Requested {n} colors, function can only return colors up to the base palette's length ({len(palette)})")
return tuple( palette[math.floor(i)] for i in np.linspace(0, len(palette)-1, num=n) )
# Optimization: avoid generator/math.floor overhead by using integer numpy indices
# np.linspace(..., dtype=int) can produce duplicated indices if palette size < n,
# but this only happens with n > palette, which is checked above
indices = np.linspace(0, len(palette) - 1, num=n)
idx = indices.astype(int)
# Use tuple comprehension, not generator, to maintain signature and behavior
return tuple(palette[i] for i in idx)

def diverging_palette(palette1: Palette, palette2: Palette, n: int, midpoint: float = 0.5) -> Palette:
""" Generate a new palette by combining exactly two input palettes.
Expand Down