Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,6 @@ services that Sagittarius must implement as a server.
├── flow_definition - Defines a definition for a Flow
├── runtime_function_definition - Defines types for runtime functions
├── struct - Defines types for json representations
└── translation - Contains translations with country codes and translated messages
├── translation - Contains translations with country codes and translated messages
└── version - Contains verion type for definitions
```
20 changes: 20 additions & 0 deletions proto/sagittarius/sagittarius.text_execution.proto
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,26 @@ message TestExecutionResponse {
}

message Log {
oneof kind {
ApplicationLog application_log = 1;
SuccessLog success_log = 2;
RuntimeErrorLog error_log = 3;
}
}

message SuccessLog {
int64 note_id = 1;
shared.Value result = 2;
}
Comment on lines +32 to +35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also store what got parsed in. So the parameter values


message RuntimeErrorLog {
int64 note_id = 1;
string error_code = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should specify this further. We errors can be emitted

string error_message = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have an error_code a message is not needed

optional string suggestion = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not come from the runtime component. This should be handled inside IDE

}

message ApplicationLog {
string message = 1;
string level = 2;
string timestamp = 3;
Comment on lines +44 to 47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite getting the purpose of this log type

Expand Down