-
Notifications
You must be signed in to change notification settings - Fork 0
Adjust Logs #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adjust Logs #153
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,26 @@ message TestExecutionResponse { | |
| } | ||
|
|
||
| message Log { | ||
| oneof kind { | ||
| ApplicationLog application_log = 1; | ||
| SuccessLog success_log = 2; | ||
| RuntimeErrorLog error_log = 3; | ||
| } | ||
| } | ||
|
|
||
| message SuccessLog { | ||
| int64 note_id = 1; | ||
| shared.Value result = 2; | ||
| } | ||
|
|
||
| message RuntimeErrorLog { | ||
| int64 note_id = 1; | ||
| string error_code = 2; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should specify this further. We errors can be emitted |
||
| string error_message = 3; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we have an error_code a message is not needed |
||
| optional string suggestion = 4; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not come from the runtime component. This should be handled inside IDE |
||
| } | ||
|
|
||
| message ApplicationLog { | ||
| string message = 1; | ||
| string level = 2; | ||
| string timestamp = 3; | ||
|
Comment on lines
+44
to
47
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not quite getting the purpose of this log type |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also store what got parsed in. So the parameter values