Adjust Logs #153
Draft
Adjust Logs #153
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosammito
reviewed
Nov 11, 2025
| int64 note_id = 1; | ||
| string error_code = 2; | ||
| string error_message = 3; | ||
| optional string suggestion = 4; |
Contributor
There was a problem hiding this comment.
This should not come from the runtime component. This should be handled inside IDE
|
|
||
| message RuntimeErrorLog { | ||
| int64 note_id = 1; | ||
| string error_code = 2; |
Contributor
There was a problem hiding this comment.
We should specify this further. We errors can be emitted
| message RuntimeErrorLog { | ||
| int64 note_id = 1; | ||
| string error_code = 2; | ||
| string error_message = 3; |
Contributor
There was a problem hiding this comment.
If we have an error_code a message is not needed
Comment on lines
+32
to
+35
| message SuccessLog { | ||
| int64 note_id = 1; | ||
| shared.Value result = 2; | ||
| } |
Contributor
There was a problem hiding this comment.
We should also store what got parsed in. So the parameter values
Comment on lines
+44
to
47
| message ApplicationLog { | ||
| string message = 1; | ||
| string level = 2; | ||
| string timestamp = 3; |
Contributor
There was a problem hiding this comment.
I'm not quite getting the purpose of this log type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea: instead of returning just application logs we can also log the result of evey node_function.
Instead of having just
Logwe would have:ApplicationLog=> Log from the ApplicationSuccessLog=> Result of a successful node_function executionRuntimeErrorLog=> Result of an unsuccessful node_function executionWhat do you think @Taucher2003 @nicosammito