-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Skip running test on Firefox due to cypress compatibility issue #14612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+0
−6
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cc3e3f3
Add temp workflow for testing
osama-rizk 9c83159
update
osama-rizk 034c6a6
comment to trigger lts checks
osama-rizk 7720186
comment to trigger lts checks
osama-rizk a3174c1
comment to trigger lts checks
osama-rizk 5386984
This is a comment to trigger lts checks
osama-rizk 09c48ba
test fix firefox amplify js V5
osama-rizk a37d8d2
commit to trigger integration tests
osama-rizk e1dc860
Skip firefox because of build issue.
osama-rizk 31cbf4f
Delete .github/workflows/temp-e2e-verification.yml
osama-rizk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: The title says sipping Firefox, but here we're removing
edgebrowser as well. Is it intentional?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for "edge" it does not matter remove it or keep as we do not use this list. We are just using
minimal_browser_listwhich contains only Firefox and chrome.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a release action flow in which we are running only chrome and firefox (tests failed due to cypress issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocker, if we don't use this list, what is the value to keep it? Should we remove the list?