Skip running test on Firefox due to cypress compatibility issue #14612
Conversation
osama-rizk
force-pushed
the
fix/v5-e2e-tests
branch
from
871605e to
a37d8d2
Compare
osama-rizk
changed the title
| extended_browser_list: &extended_browser_list | ||
| - chrome | ||
| - firefox | ||
| - edge |
There was a problem hiding this comment.
question: The title says sipping Firefox, but here we're removing edge browser as well. Is it intentional?
There was a problem hiding this comment.
for "edge" it does not matter remove it or keep as we do not use this list. We are just using minimal_browser_list which contains only Firefox and chrome.
There was a problem hiding this comment.
Here is a release action flow in which we are running only chrome and firefox (tests failed due to cypress issue)
There was a problem hiding this comment.
for "edge" it does not matter remove it or keep as we do not use this list.
non-blocker, if we don't use this list, what is the value to keep it? Should we remove the list?
| extended_browser_list: &extended_browser_list | ||
| - chrome | ||
| - firefox | ||
| - edge |
There was a problem hiding this comment.
for "edge" it does not matter remove it or keep as we do not use this list.
non-blocker, if we don't use this list, what is the value to keep it? Should we remove the list?
3 participants
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.