Skip to content

fix: emit event on delete accounts #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rictorlome wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: emit event on delete accounts #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/service-worker/src/services/accounts/events/accountsChangedEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,6 @@ export class AccountsChangedEvents implements DAppEventEmitter {
? [addressC]
: [];

// access state of the dApp didn't change, we can return early
if (
JSON.stringify(accounts) === JSON.stringify(this._dappAccessibleAccounts)
) {
return;
}

Comment on lines -71 to -77
Copy link
Member

@meeh0w meeh0w Nov 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not make Core Web or other dApps refresh unexpectedly?

this._dappAccessibleAccounts = accounts;
this.eventEmitter.emit('update', {
method: Web3Event.ACCOUNTS_CHANGED,
Expand Down
Loading