fix: emit event on delete accounts #484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
reviewed
Nov 10, 2025
Comment on lines
-71
to
-77
| // access state of the dApp didn't change, we can return early | ||
| if ( | ||
| JSON.stringify(accounts) === JSON.stringify(this._dappAccessibleAccounts) | ||
| ) { | ||
| return; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Does it not make Core Web or other dApps refresh unexpectedly?
meeh0w
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://ava-labs.atlassian.net/browse/CP-12448
Changes
Testing
Screenshots:
Checklist for the author
Tick each of them when done or if not applicable.