Skip to content

fix: install a library missing from local library-index #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 7, 2025
Merged

fix: install a library missing from local library-index #50

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6726e4e
feat: enhance AddSketchLibrary to update library index and log progress
dido18 Nov 6, 2025
e5a0282
fix: improve library index update handling in AddSketchLibrary
dido18 Nov 6, 2025
38b5c12
fix: improve error handling in AddSketchLibrary by logging warnings i…
dido18 Nov 6, 2025
3d622cf
fix: extend library index update interval to 60 seconds for improved …
dido18 Nov 6, 2025
4ef6145
fix: update library index refresh interval to 10 minutes for improved…
dido18 Nov 7, 2025
9efb92a
fix: improve error handling in AddSketchLibrary by logging warnings f…
dido18 Nov 7, 2025
4dd6ee6
Update internal/orchestrator/sketch_libs.go
dido18 Nov 7, 2025
ebc9d12
Update internal/orchestrator/sketch_libs.go
dido18 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions internal/orchestrator/sketch_libs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ package orchestrator

import (
"context"
"log/slog"
"time"

"github.com/arduino/arduino-cli/commands"
rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
Expand All @@ -25,6 +27,8 @@ import (
"github.com/arduino/arduino-app-cli/internal/orchestrator/app"
)

const indexUpdateInterval = 10 * time.Minute

func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryReleaseID, addDeps bool) ([]LibraryReleaseID, error) {
srv := commands.NewArduinoCoreServer()
var inst *rpc.Instance
Expand All @@ -43,6 +47,15 @@ func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryRel
return nil, err
}

stream, _ := commands.UpdateLibrariesIndexStreamResponseToCallbackFunction(ctx, func(curr *rpc.DownloadProgress) {
slog.Debug("downloading library index", "progress", curr.GetMessage())
})
// update the local library index after a certain time, to avoid if a library is added to the sketch but the local library index is not update, the compile can fail (because the lib is not found)
req := &rpc.UpdateLibrariesIndexRequest{Instance: inst, UpdateIfOlderThanSecs: int64(indexUpdateInterval.Seconds())}
if err := srv.UpdateLibrariesIndex(req, stream); err != nil {
slog.Warn("error updating library index, skipping", slog.String("error", err.Error()))
}

resp, err := srv.ProfileLibAdd(ctx, &rpc.ProfileLibAddRequest{
Instance: inst,
SketchPath: app.MainSketchPath.String(),
Expand All @@ -59,6 +72,7 @@ func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryRel
if err != nil {
return nil, err
}

return f.Map(resp.GetAddedLibraries(), rpcProfileLibReferenceToLibReleaseID), nil
}

Expand Down