Jira 832 Sketch cannot exercise BLE broadcast, git 420 #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidLeung
requested review from
bigdinotech,
eriknyquist,
noelpaz and
russmcinnis
Contributor
Author
|
@bigdinotech , @eriknyquist , this is PR #437 without the sample sketch. Please review. @russmcinnis , @noelpaz , please perform system test. |
eriknyquist
approved these changes
Feb 22, 2017
Root Cause:
Need to restart advertising after setting the broadcast option
in Characteristic. Otherwise, broadcasting would not take
effect.
Code mods:
1. libraries/CurieBLE/src/BLECharacteristic.cpp:
- At the processing of the Boardcast option in the
characteristic, stop and restart advertising if advertising
has already started.
Contributor
Author
|
@yashaswini-hanji , please merge this PR to main and close out Jira 832. |
Contributor
|
PR merged and closed Jira 832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause:
Need to restart advertising after setting the broadcast option
in Characteristic. Otherwise, broadcasting would not take
effect.
Code mods:
characteristic, stop and restart advertising if advertising
has already started.