Skip to content

Conversation

@sgbihu
Copy link
Contributor

@sgbihu sgbihu commented Feb 13, 2017

  1. Add example sketch
    libraries/CurieBLE/examples/peripheral/broadcast

1. Add example sketch
    libraries/CurieBLE/examples/peripheral/broadcast
2. Fix the CurieBLE can't send Advertisement when call broadcast.
Copy link
Contributor

@eriknyquist eriknyquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a license and sketch description, like I've been asking for all of your example sketches.

@SidLeung
Copy link
Contributor

@sgbihu , I think you are using the sketch from Don Coleman @ gitHub. I am asking him to put in a licensing header before we pull it in as part of the CoreLibs release.

@calvinatintel , @yashaswini-hanji , is there a procedure to take sketch from GItHub and use it in our coreLibs? I suppose we just need the proper licensing. Am I correct?

@calvinatintel
Copy link
Contributor

What's the license of the original sketch? Can you give me a link to it?

@SidLeung
Copy link
Contributor

@calvinatintel , @yashaswini-hanji , it is code from someone's gitHub request,

#420

I did ask him for licensing. Please check out the end of the threat.

@SidLeung
Copy link
Contributor

In light of the fact that the sample sketch is not public, another PR without the sample sketch is generated,

#438

This PR will be closed.

@SidLeung
Copy link
Contributor

This PR is replaced by #438.

@noelpaz
Copy link
Contributor

noelpaz commented Feb 22, 2017

I tested the sketch and the way to test this in NRF is to just scan but you cannot connect and do not connect. You should see the Service data incrementing.

The caveat is that if you central app stops scanning then the Service data will stop. Just refresh the scan and you should see the incrementing value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants