Skip to content

Fix model_wrapper_cfg with pure python style config #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 4, 2025
Merged

Fix model_wrapper_cfg with pure python style config #25

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2575aeb
lint
MGAMZ Dec 1, 2025
6990d7f
use `isclass` for clarity
MGAMZ Dec 2, 2025
1ac0079
Replace AssertionError with TypeError
MGAMZ Dec 4, 2025
d5bfa7e
Add test unit for pure-python-style config inited runner under distri…
MGAMZ Dec 4, 2025
b80838e
fix test
MGAMZ Dec 4, 2025
2678222
Support pretty_text config item when `isclass(item)`
MGAMZ Dec 4, 2025
7523faa
Fix distributed test
MGAMZ Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions mmengine/runner/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import warnings
from collections import OrderedDict
from functools import partial
from inspect import isclass
from typing import Callable, Dict, List, Optional, Sequence, Union

import torch
Expand Down Expand Up @@ -902,8 +903,13 @@ def wrap_model(
find_unused_parameters=find_unused_parameters)
else:
model_wrapper_cfg.setdefault('type', 'MMDistributedDataParallel')
model_wrapper_type = MODEL_WRAPPERS.get(
model_wrapper_cfg.get('type')) # type: ignore
model_wrapper_type = model_wrapper_cfg.get('type')
if isinstance(model_wrapper_type, str):
model_wrapper_type = MODEL_WRAPPERS.get(model_wrapper_type)
else:
assert isclass(
model_wrapper_type), 'type should be a string or a class'

default_args: dict = dict()
if issubclass(
model_wrapper_type, # type: ignore
Expand Down