Skip to content

Fix model_wrapper_cfg with pure python style config #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix model_wrapper_cfg with pure python style config #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2575aeb
lint
MGAMZ Dec 1, 2025
6990d7f
use `isclass` for clarity
MGAMZ Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions mmengine/runner/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import warnings
from collections import OrderedDict
from functools import partial
from inspect import isclass
from typing import Callable, Dict, List, Optional, Sequence, Union

import torch
Expand Down Expand Up @@ -902,8 +903,13 @@ def wrap_model(
find_unused_parameters=find_unused_parameters)
else:
model_wrapper_cfg.setdefault('type', 'MMDistributedDataParallel')
model_wrapper_type = MODEL_WRAPPERS.get(
model_wrapper_cfg.get('type')) # type: ignore
model_wrapper_type = model_wrapper_cfg.get('type')
if isinstance(model_wrapper_type, str):
model_wrapper_type = MODEL_WRAPPERS.get(model_wrapper_type)
else:
assert isclass(
model_wrapper_type), 'type should be a string or a class'
Comment on lines +910 to +911
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertion should raise a TypeError instead of using an assert statement for better error handling. Assert statements can be disabled with Python optimization flags (-O), making this validation unreliable in production. Consider:

if not isclass(model_wrapper_type):
    raise TypeError('type should be a string or a class')
Suggested change
assert isclass(
model_wrapper_type), 'type should be a string or a class'
if not isclass(model_wrapper_type):
raise TypeError('type should be a string or a class')

Copilot uses AI. Check for mistakes.
Comment on lines +906 to +911
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new functionality that allows passing a class directly as the type value (instead of a string) lacks test coverage. Consider adding a test case that validates this behavior:

# Example test case
cfg.model_wrapper_cfg = dict(type=CustomModelWrapper)  # Pass class directly
runner = Runner.from_cfg(cfg)
self.assertIsInstance(runner.model, CustomModelWrapper)

Copilot uses AI. Check for mistakes.

default_args: dict = dict()
if issubclass(
model_wrapper_type, # type: ignore
Expand Down