refactor: Remove superfluous variable init comments

[bobtista]

• Closes //Added By Sadullah Nader #1829

[Skyaero42]

You should also check for unnecessary blank lines that result from the removal of these comments.

[bobtista]

Ok I found a bunch and removed them. At some point we should use prettier or clang-tidy or something and unify the formatting across the repo.

[Skyaero42]

There are quite a few left that imho should be dealt with in this PR, because they are part of the comments

e.g.

    // End Add
    

		// Added By Sadullah Nader
		// Initialization missing and needed

		m_putInContainerName.clear();

I think you need to look above and below the removed comments and remove empty lines

[bobtista]

I've been going through and manually looking at files for a few hours now. Sometimes the empty lines above or below where Nader's comments lived are perfectly reasonable - eg the blocks of code would have had an empty line anyway, eg when variables are grouped or there are just newlines every n lines of assignments for style/readabilty. I'm about 1/4 of the way through reviewing all of the comments individually, addressing the empty lines around them, and feeling like I'm really using my time poorly.

If you have an idea for a script here I'm happy to chat about this more. For now I'm going to take a break. I'll push the latest changes when able (git is down) EDIT: pushed latest

[Skyaero42]

I went through all the changed files.

I think these are the last ones that could be removed.

[xezon]

Mr Nader left a lot of work here for us.

[xezon]

Given Generals and GeneralsMD files were touched individually by hand, how confident are we that the edits are in sync?

[xezon]

Initialization missing here. Can fix in separate change.

[bobtista]

Given Generals and GeneralsMD files were touched individually by hand, how confident are we that the edits are in sync?

I ran a script - The only "mismatches" are comments that existed in one codebase but not the other (e.g., Generals had "//Fixed And Added Code By Sadullah Nader" which GeneralsMD never had) so the removal only happened there.

[xezon]

Ok. It is impossible to verify that the edits are consistent between the games but we can live with it if they are some discrepancies. They will be merged later anyway.

[Skyaero42]

What you can do is create diffs for the generals and generalsMD directories and then use winmerge to compare:

git diff superhackers/main -- GeneralsMD > /tmp/diff_generalsmd.patch
git diff superhackers/main -- Generals > /tmp/diff_generals.patch

I've marked the differences.

[Skyaero42]

Remove line to be consistent with Generals

[xezon]

Looks ok as far as I can tell.

[xezon]

There are merge conflicts now.

[Skyaero42]

All good now

[xezon]

The trash has been taken out. I was looking forward to this day.