refactor: remove repetitive author attribution comments #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobtista
commented
Nov 11, 2025
bobtista
commented
- Closes //Added By Sadullah Nader #1829
xezon
reviewed
Nov 14, 2025
xezon
added
the
Refactor
bobtista
force-pushed
the
bobtista/remove-sadullah-nader-comments
branch
from
492a24d to
fd3c033
Compare
Skyaero42
requested changes
Nov 17, 2025
Skyaero42
left a comment
Skyaero42
left a comment
There was a problem hiding this comment.
This needs another pass.
I've only looked at Generals
Generals/Code/GameEngine/Include/GameLogic/Module/DeliverPayloadAIUpdate.h
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/ParkingPlaceBehavior.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameLogic/Object/Collide/CrateCollide/CrateCollide.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/DeliverPayloadAIUpdate.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameLogic/Object/Update/BattlePlanUpdate.cpp
Outdated
Show resolved
Hide resolved
bobtista
force-pushed
the
bobtista/remove-sadullah-nader-comments
branch
3 times, most recently
from
bc31db4 to
9723dee
Compare
xezon
reviewed
Nov 17, 2025
bobtista
force-pushed
the
bobtista/remove-sadullah-nader-comments
branch
from
9723dee to
875acd2
Compare
xezon
reviewed
Nov 17, 2025
Core/GameEngine/Source/GameNetwork/GameSpy/Thread/PersistentStorageThread.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Include/GameLogic/Module/ObjectDefectionHelper.h
Show resolved
Hide resolved
Generals/Code/GameEngine/Include/GameLogic/Module/StructureCollapseUpdate.h
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/QuitMenu.cpp
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ScoreScreen.cpp
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLGameSetupMenu.cpp
Show resolved
Hide resolved
Author
|
Started over, used a script, then went and looked through things from the comments here for edge cases to handle after. PR #1876 |
|
So this one can be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.