Skip to content

Conversation

@bhavyaa30
Copy link
Contributor

PR Description:

Pull Request Checklist

Overview

  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@mskoddow mskoddow self-assigned this Oct 3, 2025
@mskoddow
Copy link
Contributor

mskoddow commented Oct 3, 2025

Please rewrite the script completely and follow best ServiceNow's best practices.
Add a more meaningful description and how to use it.
Don't mix it with Flow Designer without explaining how to utilize it there.

@mskoddow mskoddow closed this Oct 3, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but that script is full of issues and makes no sense at all. I don't know where to start and in the end I cannot rewrite everything for you.

However, at least one important hint. The code line "child.parent_incident.update()" will not work. If you want to update the parent record you have to load an individual instance, for example with "getRefRecord()"
For more information please refer https://support.servicenow.com/kb?id=kb_article_view&sysparm_article=KB0745222

And also "hello" loggings do not provide any value and spam the syslog table!

@bhavyaa30 bhavyaa30 deleted the Close-Parent-Incident-If-All-Child-Incident-Is-Closed branch October 3, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants