Skip to content

feat: make RequestEvent readonly instead of frozen #8135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −7
Open

feat: make RequestEvent readonly instead of frozen #8135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaggy-items-send.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@builder.io/qwik-city': patch
---

Make RequestEvents readonly instead of frozen
14 changes: 7 additions & 7 deletions packages/qwik-city/src/middleware/request-handler/request-event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,15 +319,15 @@ export function createRequestEvent(
return writableStream;
},
};
return Object.freeze(requestEv);
return requestEv;
}

export interface RequestEventInternal extends RequestEvent, RequestEventLoader {
[RequestEvLoaders]: Record<string, ValueOrPromise<unknown> | undefined>;
[RequestEvMode]: ServerRequestMode;
[RequestEvTrailingSlash]: boolean;
[RequestEvRoute]: LoadedRoute | null;
[RequestEvQwikSerializer]: QwikSerializer;
export interface RequestEventInternal extends Readonly<RequestEvent>, Readonly<RequestEventLoader> {
readonly [RequestEvLoaders]: Record<string, ValueOrPromise<unknown> | undefined>;
readonly [RequestEvMode]: ServerRequestMode;
readonly [RequestEvTrailingSlash]: boolean;
readonly [RequestEvRoute]: LoadedRoute | null;
readonly [RequestEvQwikSerializer]: QwikSerializer;

/**
* Check if this request is already written to.
Expand Down