Skip to content

Conversation

@DustinJSilk
Copy link
Contributor

What is it?

  • Feature
  • types

Description

Switch from freezing RequestEvents to using readonly so that users can extend the RequestEvent while keeping the event safe from malpractice internally.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@DustinJSilk DustinJSilk requested a review from a team as a code owner November 7, 2025 14:00
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

🦋 Changeset detected

Latest commit: 1db1a0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch
@builder.io/qwik-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@8135
npm i https://pkg.pr.new/@builder.io/qwik-city@8135
npm i https://pkg.pr.new/eslint-plugin-qwik@8135
npm i https://pkg.pr.new/create-qwik@8135

commit: 1db1a0b

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1db1a0b

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens moved this from Backlog to Waiting For Review in Qwik Development Nov 7, 2025
@wmertens
Copy link
Member

wmertens commented Nov 7, 2025

We'll discuss this in next week's core meeting but looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting For Review

Development

Successfully merging this pull request may close these issues.

2 participants