feat!: make sure constructors don't get optimised out

.github/workflows/linux.yml

@@ -26,7 +26,12 @@ jobs:
 
   test-linux:
     name: Test Linux
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.config.os }}
+    strategy:
+      matrix:
+        config:
+          - { os: "ubuntu-latest" }
+          - { os: "ubuntu-24.04-arm" }
     container: ghcr.io/plc-lang/rust-llvm:latest
     steps:
       - uses: actions/checkout@v3

.github/workflows/lit.yml

@@ -12,7 +12,12 @@ on:
 jobs:
   lit-linux-debug:
     name: lit tests (Linux, debug build)
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.config.os }}
+    strategy:
+      matrix:
+        config:
+          - { os: "ubuntu-latest" }
+          - { os: "ubuntu-24.04-arm" }
     container: ghcr.io/plc-lang/rust-llvm:latest
     steps:
       - uses: actions/checkout@v3
@@ -25,11 +30,16 @@ jobs:
   lit-linux-release:
     name: lit tests (Linux, release build)
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        config:
+          - { os: "ubuntu-latest" }
+          - { os: "ubuntu-24.04-arm" }
     container: ghcr.io/plc-lang/rust-llvm:latest
     steps:
       - uses: actions/checkout@v3
 
       - name: Run `build.sh --lit --release`
         shell: bash
         run: |
-          ./scripts/build.sh --lit --release
+          ./scripts/build.sh --lit --release

Cargo.toml

@@ -23,6 +23,7 @@ plc_util = { path = "./compiler/plc_util" }
 plc_diagnostics = { path = "./compiler/plc_diagnostics" }
 plc_index = { path = "./compiler/plc_index" }
 section_mangler = { path = "./compiler/section_mangler" }
+plc_llvm = { path = "./compiler/plc_llvm" }
 logos = "0.12.0"
 clap = { version = "3.0", features = ["derive"] }
 indexmap = "2.0"
@@ -31,6 +32,7 @@ regex = "1"
 shell-words = "1.1.0"
 plc_derive = { path = "./compiler/plc_derive" }
 lld_rs = { git = "https://github.com/mun-lang/lld-rs", rev = "3798ace" }
+
 which = "4.2.5"
 log.workspace = true
 inkwell.workspace = true
@@ -79,6 +81,7 @@ members = [
     "compiler/plc_index",
     "compiler/section_mangler",
     "compiler/plc_lowering",
+    "compiler/plc_llvm",
     "tests/test_utils",
 ]
 default-members = [".", "compiler/plc_driver", "compiler/plc_xml"]

compiler/plc_driver/src/cli.rs

@@ -120,9 +120,9 @@ pub struct CompileParameters {
         name = "no-linker-script",
         long,
         global = true,
-        group = "linker_script",
         help = "Specify that no linker script should be used"
     )]
+    #[deprecated = "Does nothing"]
     pub no_linker_script: bool,
 
     #[clap(

compiler/plc_driver/src/lib.rs

@@ -88,9 +88,10 @@ pub struct LinkOptions {
 
 #[derive(Clone, Default, Debug)]
 pub enum LinkerScript {
-    #[default]
+    #[deprecated = "No longer used, the default build script is enough"]
     Builtin,
     Path(String),
+    #[default]
     None,
 }
 

compiler/plc_driver/src/pipelines.rs

@@ -18,7 +18,6 @@ use ast::{
 };
 
 use itertools::Itertools;
-use log::debug;
 use participant::{PipelineParticipant, PipelineParticipantMut};
 use plc::{
     codegen::{CodegenContext, GeneratedModule},
@@ -51,7 +50,6 @@ use rayon::prelude::*;
 use source_code::{source_location::SourceLocation, SourceContainer};
 
 use serde_json;
-use tempfile::NamedTempFile;
 use toml;
 
 pub mod participant;
@@ -203,11 +201,7 @@ impl<T: SourceContainer> BuildPipeline<T> {
 
             library_paths.extend_from_slice(self.project.get_library_paths());
             //Get the specified linker script or load the default linker script in a temp file
-            let linker_script = if params.no_linker_script {
-                LinkerScript::None
-            } else {
-                params.linker_script.clone().map(LinkerScript::Path).unwrap_or_default()
-            };
+            let linker_script = params.linker_script.clone().map(LinkerScript::Path).unwrap_or_default();
 
             LinkOptions {
                 libraries,
@@ -983,29 +977,11 @@ impl GeneratedProject {
                 //HACK: Create a temp file that would contain the bultin linker script
                 //FIXME: This has to be done regardless if the file is used or not because it has
                 //to be in scope by the time we call the linker
-                let mut file = NamedTempFile::new()?;
                 match link_options.linker_script {
-                    LinkerScript::Builtin => {
-                        let target = self.target.get_target_triple().to_string();
-                        //Only do this on linux systems
-                        if target.contains("linux") {
-                            if target.contains("x86_64") {
-                                let content = include_str!("../../../scripts/linker/x86_64.script");
-                                writeln!(file, "{content}")?;
-                                linker.set_linker_script(file.get_location_str().to_string());
-                            } else if target.contains("aarch64") {
-                                let content = include_str!("../../../scripts/linker/aarch64.script");
-                                writeln!(file, "{content}")?;
-                                linker.set_linker_script(file.get_location_str().to_string());
-                            } else {
-                                debug!("No script for target : {target}");
-                            }
-                        } else {
-                            debug!("No script for target : {target}");
-                        }
-                    }
                     LinkerScript::Path(script) => linker.set_linker_script(script),
                     LinkerScript::None => {}
+                    #[allow(deprecated)]
+                    LinkerScript::Builtin => {}
                 };
 
                 match link_options.format {

compiler/plc_driver/src/tests/external_files.rs

@@ -9,7 +9,7 @@ fn external_file_function_call() {
     //Given a program calling a function from an external file
     let prog = SourceCode::new(
         "
-    FUNCTION main : INT
+    FUNCTION main : DINT
         external();
     END_FUNCTION
     ",
@@ -18,7 +18,7 @@ fn external_file_function_call() {
 
     let ext = SourceCode::new(
         "
-    FUNCTION external : INT
+    FUNCTION external : DINT
     END_FUNCTION
     ",
         "external.st",
@@ -34,7 +34,7 @@ fn external_file_global_var() {
     //Given a program calling a function from an external file
     let prog = SourceCode::new(
         "
-    FUNCTION main : INT
+    FUNCTION main : DINT
         x := 2;
         y := 2;
         external();
@@ -48,7 +48,7 @@ fn external_file_global_var() {
     VAR_GLOBAL
         x : INT;
     END_VAR
-    FUNCTION external : INT
+    FUNCTION external : DINT
     END_FUNCTION
     VAR_GLOBAL
         y : INT;
@@ -67,7 +67,7 @@ fn calling_external_file_function_without_including_file_results_in_error() {
     //Given a program calling a function from an external file
     let prog = SourceCode::new(
         "
-    FUNCTION main : INT
+    FUNCTION main : DINT
         external();
     END_FUNCTION
     ",

compiler/plc_driver/src/tests/multi_files.rs

@@ -9,7 +9,7 @@ fn multiple_source_files_generated() {
     //Given 2 sources
     let src1 = SourceCode::new(
         "
-    FUNCTION main : INT
+    FUNCTION main : DINT
     VAR_INPUT
 
     END_VAR
@@ -45,7 +45,7 @@ fn multiple_files_with_debug_info() {
     //Given 2 sources
     let src1: SourceCode = SourceCode::new(
         "
-    FUNCTION main : INT
+    FUNCTION main : DINT
     VAR_INPUT
 
     END_VAR
@@ -84,7 +84,7 @@ fn multiple_files_in_different_locations_with_debug_info() {
     //Given 2 sources
     let src1: SourceCode = SourceCode::new(
         "
-    FUNCTION main : INT
+    FUNCTION main : DINT
     VAR_INPUT
 
     END_VAR
@@ -125,7 +125,7 @@ fn forward_declared_constant_is_also_marked_constant() {
     // and the other with the definition of that constant.
     let src1 = SourceCode::new(
         "
-    FUNCTION main : INT
+    FUNCTION main : DINT
     VAR
         f: foo;
     END_VAR

compiler/plc_driver/src/tests/snapshots/plc_driver__tests__external_files__external_file_function_call.snap

@@ -1,37 +1,36 @@
 ---
-source: compiler/plc_driver/./src/tests/external_files.rs
+source: compiler/plc_driver/src/tests/external_files.rs
 expression: "results.join(\"\\n\")"
-snapshot_kind: text
 ---
 ; ModuleID = 'main.st'
 source_filename = "main.st"
 target datalayout = "[filtered]"
 target triple = "[filtered]"
 
-define i16 @main() {
+define i32 @main() {
 entry:
-  %main = alloca i16, align 2
-  store i16 0, i16* %main, align 2
-  %call = call i16 @external()
-  %main_ret = load i16, i16* %main, align 2
-  ret i16 %main_ret
+  %main = alloca i32, align [filtered]
+  store i32 0, i32* %main, align [filtered]
+  %call = call i32 @external()
+  %main_ret = load i32, i32* %main, align [filtered]
+  ret i32 %main_ret
 }
 
-declare i16 @external()
+declare i32 @external()
 
 ; ModuleID = 'external.st'
 source_filename = "external.st"
 target datalayout = "[filtered]"
 target triple = "[filtered]"
 
-declare i16 @external()
+declare i32 @external()
 
 ; ModuleID = '__init___TestProject'
 source_filename = "__init___TestProject"
 target datalayout = "[filtered]"
 target triple = "[filtered]"
 
-@llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 0, void ()* @__init___TestProject, i8* null }]
+@llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @__init___TestProject, i8* null }]
 
 define void @__init___TestProject() {
 entry:

compiler/plc_driver/src/tests/snapshots/plc_driver__tests__external_files__external_file_global_var.snap

@@ -1,7 +1,6 @@
 ---
-source: compiler/plc_driver/./src/tests/external_files.rs
+source: compiler/plc_driver/src/tests/external_files.rs
 expression: "results.join(\"\\n\")"
-snapshot_kind: text
 ---
 ; ModuleID = 'main.st'
 source_filename = "main.st"
@@ -11,18 +10,18 @@ target triple = "[filtered]"
 @x = external global i16
 @y = external global i16
 
-define i16 @main() {
+define i32 @main() {
 entry:
-  %main = alloca i16, align 2
-  store i16 0, i16* %main, align 2
-  store i16 2, i16* @x, align 2
-  store i16 2, i16* @y, align 2
-  %call = call i16 @external()
-  %main_ret = load i16, i16* %main, align 2
-  ret i16 %main_ret
+  %main = alloca i32, align [filtered]
+  store i32 0, i32* %main, align [filtered]
+  store i16 2, i16* @x, align [filtered]
+  store i16 2, i16* @y, align [filtered]
+  %call = call i32 @external()
+  %main_ret = load i32, i32* %main, align [filtered]
+  ret i32 %main_ret
 }
 
-declare i16 @external()
+declare i32 @external()
 
 ; ModuleID = 'external.st'
 source_filename = "external.st"
@@ -32,14 +31,14 @@ target triple = "[filtered]"
 @x = external global i16
 @y = external global i16
 
-declare i16 @external()
+declare i32 @external()
 
 ; ModuleID = '__init___TestProject'
 source_filename = "__init___TestProject"
 target datalayout = "[filtered]"
 target triple = "[filtered]"
 
-@llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 0, void ()* @__init___TestProject, i8* null }]
+@llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @__init___TestProject, i8* null }]
 
 define void @__init___TestProject() {
 entry: