feat!: make sure constructors don't get optimised out #1540
+7,229
−7,729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghaith
force-pushed
the
fix_arm_constructors
branch
3 times, most recently
from
18437fb to
750d3e5
Compare
adds a new plc_llvm crate that wraps llvm c++ apis. The only api currently provided is to expose the init array flag. This ensures that the constructors created by the compiler are actually called in aarch64 architectures.
ghaith
force-pushed
the
fix_arm_constructors
branch
from
38bae86 to
8b4e085
Compare
ghaith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an LLVM C++ Wrapper that provides access to mark the compiled application to use the elf .init_array constructors.
Removes the built in linker scripts and deprecates the --no-linker-script flag.
This is a breaking change as the init functions are no longer visible in the binary.
This PR also activates builds on aarch64 (arm64) and for that we needed to filter out alignmets from all the tests.
We are still missing a test that explicitly tests alignments.