Skip to content

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Nov 11, 2025

Summary by CodeRabbit

  • Tests
    • Updated test skip configurations to address identified issues.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "H100_PCIe-PyTorch-2"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025

📝 Walkthrough

Walkthrough

Added three new test skip entries to the integration test waives list, each marked with a link to nvbugs/5651917. The tests are for speculative execution features (EAGLE3 and N-gram).

Changes

Cohort / File(s) Summary
Test waives configuration
tests/integration/test_lists/waives.txt
Added three new skip entries for speculative execution tests: test_eagle3_cuda_graph_padding[True], test_llama_ngram[True-False-FLASHINFER], and test_llama_eagle3[False-TRTLLM-False-False-False-False-False-True-False], each referencing nvbugs/5651917

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • These are simple, repetitive skip entries added to a test configuration file with no logic changes or functional modifications.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions waiving failed cases but the actual changes waive multiple tests in speculative modules, not just disaggregated/test_disaggregated.py as stated. Update the title to accurately reflect that tests in unittest/_torch/speculative (eagle3, ngram) are being waived, not disaggregated/test_disaggregated.py.
Description check ⚠️ Warning The PR description is empty of actual content—it only contains the template structure with placeholder sections for Description and Test Coverage unfilled. Provide a concise description explaining why these tests are being waived and reference the nvbugs/5651917 issue ticket in the description.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24190 [ run ] triggered by Bot. Commit: 4ab6b19

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24190 [ run ] completed with state SUCCESS. Commit: 4ab6b19
/LLM/main/L0_MergeRequest_PR pipeline #18240 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: qqiao <qqiao@nvidia.com>
Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh EmmaQiaoCh changed the title [None][infra] Waive other timeout cases in unittest/_torch/speculative [None][infra] Waive a failed case of disaggregated/test_disaggregated.py Nov 12, 2025
@EmmaQiaoCh
Copy link
Collaborator Author

/bot skip --comment "Skip a intermittent failure since it also block pre-merge"

@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) November 12, 2025 03:06
@bobboli
Copy link
Collaborator

bobboli commented Nov 12, 2025

LGTM. We should also notify the owner of the tests.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24240 [ skip ] triggered by Bot. Commit: 4a45e7b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24240 [ skip ] completed with state SUCCESS. Commit: 4a45e7b
Skipping testing for commit 4a45e7b

@EmmaQiaoCh EmmaQiaoCh merged commit bb6eb95 into NVIDIA:main Nov 12, 2025
7 checks passed
suyoggupta pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants