Skip to content

fix: Android Namespace error #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Android Namespace error #166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fd23e5
feat: Upgrade build.grandle
Nov 4, 2024
c1a017d
feat: Remove test dependencies
robotoss Jan 26, 2025
ffa5a56
feat: Remove Kotlin dependencies
robotoss Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions flutter_keyboard_visibility/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
group 'com.jrai.flutter_keyboard_visibility'
version '1.0'
group = "com.jrai.flutter_keyboard_visibility"
version = "1.0"

buildscript {
repositories {
Expand All @@ -8,37 +8,43 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
classpath("com.android.tools.build:gradle:8.1.0")
}
}

rootProject.allprojects {
allprojects {
repositories {
google()
mavenCentral()
}
}

apply plugin: 'com.android.library'
apply plugin: "com.android.library"
apply plugin: "kotlin-android"

android {
// Conditional for compatibility with AGP <4.2.
if (project.android.hasProperty("namespace")) {
namespace 'com.jrai.flutter_keyboard_visibility'
namespace = "com.jrai.flutter_keyboard_visibility"
}

compileSdkVersion 31
compileSdk = 34
Copy link

@EchoEllet EchoEllet Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


defaultConfig {
minSdkVersion 16
compileOptions {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
}

lint {
disable 'InvalidPackage'
kotlinOptions {
jvmTarget = JavaVersion.VERSION_1_8
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceSets {
main.java.srcDirs += "src/main/kotlin"
test.java.srcDirs += "src/test/kotlin"
}

defaultConfig {
minSdk = 21
}

}