-
-
Notifications
You must be signed in to change notification settings - Fork 243
fix: Android Namespace error #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey @MisterJimson , Could you take a quick look at PR #166r? It support new version Android studio with java Thanks a lot! |
| } | ||
|
|
||
| compileSdkVersion 31 | ||
| compileSdk = 34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
EchoEllet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, while I'm not a maintainer of this repo, what is the issue you're encountering, Is it Java 8 warnings after updating to Android Ladybug?
I understand From the experience of current projects i just used the fix on Mac OS
to avoid problems with JAVA using LadyBag |
It's better to update AGP, Gradle, and the dependencies instead of changing the default Android Studio JDK. |
|
This fixed it for me, it is causing issue with most packages, so instead of changing in all packages, this should work |
|
could you please make a fork of this to add it to pubspec.yaml? |
Summary
This PR updates the
build.gradlefile to improve compatibility with the latest Android Gradle Plugin (AGP) and Kotlin version, while also enhancing the project’s structure and testing capabilities.Changes
Updated Plugin and Library Versions:
7.4.2to8.1.0.Project Group and Version:
groupandversionsyntax from Groovy-style to Kotlin-style (=syntax).Repositories:
mavenCentral()alongsidegoogle()in bothbuildscriptandallprojectsfor broader dependency resolution.Android Configuration:
namespaceconfiguration to use the Kotlin-style assignment (=) syntax for AGP compatibility.compileSdkfrom31to34.minSdkfrom16to21for improved compatibility with newer libraries.Source Sets Configuration:
sourceSetsto include Kotlin-specific directories:main.java.srcDirs += "src/main/kotlin"test.java.srcDirs += "src/test/kotlin"Code Quality and Compatibility:
kotlinOptionswithjvmTarget = JavaVersion.VERSION_1_8for consistency withcompileOptions.Impact
JUnitPlatformand standard logging configurations.