Skip to content

Fix arguments for ArrayValue.__array__() #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v1
Choose a base branch
from
+14 −4
Open

Fix arguments for ArrayValue.__array__() #718

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f810f8
Fix arguments for `ArrayValue.__array__()`
JamesWrigley Nov 12, 2025
9ac67bd
fixup! Fix arguments for `ArrayValue.__array__()`
JamesWrigley Nov 13, 2025
31e9a8c
fixup! Fix arguments for `ArrayValue.__array__()`
JamesWrigley Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/JlWrap/array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,19 +353,29 @@ function init_array()
@property
def __array_interface__(self):
return self._jl_callmethod($(pyjl_methodnum(pyjlarray_array_interface)))
def __array__(self, dtype=None):
def __array__(self, dtype=None, copy=None):
# convert to an array-like object
arr = self
if not (hasattr(arr, "__array_interface__") or hasattr(arr, "__array_struct__")):
# the second attempt collects into a PyObjectArray
arr = self._jl_callmethod($(pyjl_methodnum(pyjlarray_array__pyobjectarray)))
if copy is False:
raise ValueError("copy=False is not supported when collecting ArrayValue data")
# the first attempt collects into an Array
arr = self._jl_callmethod($(pyjl_methodnum(pyjlarray_array__array)))
if not (hasattr(arr, "__array_interface__") or hasattr(arr, "__array_struct__")):
# the second attempt collects into a PyObjectArray
arr = self._jl_callmethod($(pyjl_methodnum(pyjlarray_array__pyobjectarray)))
# convert to a numpy array if numpy is available
try:
import numpy
except ImportError:
numpy = None
if numpy is not None:
return numpy.array(arr, dtype=dtype, copy=copy, order=order)
# Numpy <2 does not support `copy=None` argument, so we have to check the version
major_version = int(numpy.__version__.split(".")[0])
if major_version < 2 and copy is None:
copy = False
arr = numpy.array(arr, dtype=dtype, copy=copy)
return arr
def to_numpy(self, dtype=None, copy=True, order="K"):
import numpy
Expand Down
Loading