Skip to content

Conversation

@JamesWrigley
Copy link
Contributor

@JamesWrigley JamesWrigley commented Nov 12, 2025

Not sure how but this was broken on the v1 branch. Maybe from a rebase mistake?

@JamesWrigley
Copy link
Contributor Author

I found some other issues with __array__():

  • The copy=None argument is not supported on numpy v1, tried fixing that with a poor mans version check in 9ac67bd.
  • It always returns a numpy array with dtype=object. I suspect this is because of the missing 'first attempt' in v1 compared to main, which I tried adding back in 31e9a8c.

Not entirely sure if my changes are correct though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant