-
-
Notifications
You must be signed in to change notification settings - Fork 9
Bs7 citations #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bs7 citations #305
Conversation
Citation link, generates modal dialog box whose content is the results of a call to Zotero to get the citation. Currently using apa citation, there are many other options...
Allow the user to copy either the formatted 'pretty' text or the raw html that creates the entry.
Move citations button to bottom of page with Zotero button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
pamoroso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works with no issues for me with Firefox and Chrome on Linux.
layouts/bibliography/single.html
Outdated
| {{- end -}} | ||
|
|
||
| <!-- Citation --> | ||
| {{/* Build Zotero API params (group id + item key + style) */}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lines that are only Hugo operations should have {{- & -}} delimiters so whitespace between them is stripped from the output. (Generally, no functional effect, but helps with readability if looking at "page source" in the browser. Also, smaller pages.
| <div class="citation-actions"> | ||
| <button type="button" id="copyCitation">Copy Text</button> | ||
| <button type="button" id="copyCitationHtml">Copy HTML</button> | ||
| <button type="button" class="citation-close">Close</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "Close" is a larger font, and no border, compared to the two buttons adjacent.
In the process I discovered a couple minor errors in the layout of the bibliography and fixed them.
Adds a citation button that brings up a modal window showing both the formatted citation and html text representing the formatted citation. Allows user to copy either option.
Issue 2349 has several screenshots.