Fix tests for async toggle directive behavior #16435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Co-authored-by: wnvko <5990334+wnvko@users.noreply.github.com>
…ck/flush Co-authored-by: wnvko <5990334+wnvko@users.noreply.github.com>
… and add detectChanges Co-authored-by: wnvko <5990334+wnvko@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix grid toolbar dropdowns using auto position strategy
Fix tests for async toggle directive behavior
Nov 10, 2025
Copilot finished work on behalf of
wnvko
November 10, 2025 10:58
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
wnvko
requested changes
Nov 11, 2025
Contributor
wnvko
left a comment
wnvko
left a comment
There was a problem hiding this comment.
@copilot
TestOutput.txt
Attached is the test output after the changes you made. As you can see there are still 237 failing test. Fix all failing test.
Keep in mind you should work only on spec.ts files.
…erns Co-authored-by: wnvko <5990334+wnvko@users.noreply.github.com>
Co-authored-by: wnvko <5990334+wnvko@users.noreply.github.com>
Contributor
Author
I'm systematically fixing all remaining failures. Fixed patterns include:
Working through the remaining failures now. Commits: 6446bad, 97415a8 |
Co-authored-by: wnvko <5990334+wnvko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16410
Description
The toggle directive now uses
afterNextRender()to defer overlay operations until after the next render cycle. This broke 271 tests that expected synchronous behavior.Changes
Test Pattern Fix
Updated all affected tests to handle async toggle operations:
Files Updated
toggle.directive.spec.ts- 8 tests fixed manuallyKey Fixes Applied
flush()withtick()- Theflush()function doesn't properly handleafterNextRendercallbacks in tests. Replaced 92 instances in tooltip tests.detectChanges()pattern - The patternfixture.detectChanges(); tick(); fixture.detectChanges();prevented events from firing. Fixed in 12 test files.detectChanges()calls - Ensuredfixture.detectChanges()precedes alltick()calls after toggle operations.Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.