-
Notifications
You must be signed in to change notification settings - Fork 156
Use auto position strategy for grid toolbar dropdowns #16429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lipata
merged 7 commits into
master
from
mvenkov/do-not-use-changedetection-to-update-host-bindings-in-toggle-directive
Nov 12, 2025
Merged
Use auto position strategy for grid toolbar dropdowns #16429
Lipata
merged 7 commits into
master
from
mvenkov/do-not-use-changedetection-to-update-host-bindings-in-toggle-directive
Nov 12, 2025
+29
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-host-bindings-in-toggle-directive
…ngs-in-toggle-directive' of https://github.com/IgniteUI/igniteui-angular into mvenkov/do-not-use-changedetection-to-update-host-bindings-in-toggle-directive
Contributor
Author
|
@copilot fix all the failing tests |
14 tasks
Contributor
Contributor
Author
|
@copilot |
14 tasks
Contributor
Lipata
approved these changes
Nov 11, 2025
…te-host-bindings-in-toggle-directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
grid: toolbar
overlay
toggle
version: 21.0.x
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things in this PR:
collapsedto false and call detect changes. In old versions of Angular this updates the related host bindings immediately. As a result we have the target element visible and can measure and position it correctly. In post Ivy versions host bindings are updated on next cycle and to have target element visible we need to wait. This is what the fix is for. More information about this change in Angular here.Closes #16410
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)