Skip to content

Conversation

@wnvko
Copy link
Contributor

@wnvko wnvko commented Nov 7, 2025

Two things in this PR:

  • fix the way toggle directive shows its target. In open method we set now collapsed to false and call detect changes. In old versions of Angular this updates the related host bindings immediately. As a result we have the target element visible and can measure and position it correctly. In post Ivy versions host bindings are updated on next cycle and to have target element visible we need to wait. This is what the fix is for. More information about this change in Angular here.
  • make the position strategy of grid toolbar dropdowns auto.
  • fix overlay animation direction change.

Closes #16410

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them toggle grid: toolbar version: 21.0.x labels Nov 7, 2025
@wnvko wnvko marked this pull request as draft November 7, 2025 08:47
@wnvko
Copy link
Contributor Author

wnvko commented Nov 7, 2025

@copilot fix all the failing tests

Copy link
Contributor

Copilot AI commented Nov 7, 2025

@wnvko I've opened a new pull request, #16430, to work on those changes. Once the pull request is ready, I'll request review from you.

@wnvko
Copy link
Contributor Author

wnvko commented Nov 10, 2025

@copilot
After the fix in this PR there are a lot of failing test. The reason for failure is that toggle directive now work asynchronously and wits for the next render. If failing test is made fakeAsync and tick is called each time toggle is open this should fix the test. What I need is you to fix all failing tests with commit to this PR.

Copy link
Contributor

Copilot AI commented Nov 10, 2025

@wnvko I've opened a new pull request, #16435, to work on those changes. Once the pull request is ready, I'll request review from you.

@wnvko wnvko added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 11, 2025
@wnvko wnvko requested a review from valadzhov November 11, 2025 13:05
@wnvko wnvko added the overlay label Nov 11, 2025
@Lipata Lipata marked this pull request as ready for review November 11, 2025 13:35
@valadzhov valadzhov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 12, 2025
@Lipata Lipata merged commit c4d55ca into master Nov 12, 2025
7 of 10 checks passed
@Lipata Lipata deleted the mvenkov/do-not-use-changedetection-to-update-host-bindings-in-toggle-directive branch November 12, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: toolbar overlay toggle version: 21.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Grid] The chosen positioning strategy for toolbar dropdowns causes them to not display their full contents in certain scenarios

4 participants