Skip to content

Tweak summarize #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tweak summarize #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c44e4e9
Improve output when clj-kondo finds problems
jcf Oct 17, 2023
dddd5e9
Extract summary logic
jcf Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ const annotationLevels = {
error: "failure"
};

function summarize({ duration, error, info, warning }) {
return `linting took ${duration}ms, errors: ${error}, warnings: ${warning}, info: ${info}`;
}

async function run() {
const id = await createCheck();
try {
Expand All @@ -94,14 +98,14 @@ async function run() {
}
await updateCheck(id, 'in-progress', {
title: checkName,
summary: `linting took ${stdout.summary.duration}ms, errors: ${stdout.summary.error}, warnings: ${stdout.summary.warning}, info: ${stdout.summary.info}`,
summary: summarize(stdout.summary),
annotations
});
}
console.log(`clj-kondo detects some problems and exited with a non-zero code (${exitCode}). Please check founded problems at https://github.com/${GITHUB_REPOSITORY}/runs/${id}`);
Copy link
Author

@jcf jcf Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lighter touch change here of something like:

clj-kondo detected some problems and exited with a non-zero code (n). Please check the problems found at https://github.com/...

I shortened things because I'm a sucker for something succinct.

console.log(`clj-kondo exited with a non-zero code (${exitCode}). Please find your report at https://github.com/${GITHUB_REPOSITORY}/runs/${id}`);
await updateCheck(id, 'failure', {
title: checkName,
summary: `linting took ${stdout.summary.duration}ms, errors: ${stdout.summary.error}, warnings: ${stdout.summary.warning}, info: ${stdout.summary.info}`,
summary: summarize(stdout.summary),
});
process.exit(78);
} else if (exitCode == 0) {
Expand Down