Tweak summarize #16
Open
Tweak summarize #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcf
commented
Oct 17, 2023
| annotations | ||
| }); | ||
| } | ||
| console.log(`clj-kondo detects some problems and exited with a non-zero code (${exitCode}). Please check founded problems at https://github.com/${GITHUB_REPOSITORY}/runs/${id}`); |
Author
There was a problem hiding this comment.
There is a lighter touch change here of something like:
clj-kondo detected some problems and exited with a non-zero code (n). Please check the problems found at https://github.com/...
I shortened things because I'm a sucker for something succinct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kirill,
Firstly, thanks for sharing the superb Clojure-orientated GitHub actions. They're much appreciated!
I noticed the output in a small reproduction I shared over in Clojurians used broken English and thought I'd share a subjective improvement for your consideration.
When in the code, I noticed some repeated logic, too, so added an additional commit that introduces a new function for summarising the linting process.
If I used the newer
const summarize => ()syntax, I could eliminate the explicitreturnbut noticed you're using the establishedfunctionsyntax, so stuck with that.Thanks again for the awesome work!