-
Notifications
You must be signed in to change notification settings - Fork 468
chore: update file paths in codeowners #15170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update file paths in codeowners #15170
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 2 ms. The average import time from base is: 242 ± 2 ms. The import time difference between this PR and base is: -3.73 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate taegyunkim/settings-owners (b03e422) with baseline 4.0-breaking-changes (4e5fa6b) 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.393ms (SLO: <22.300ms -8.6%) vs baseline: ~same Memory: ✅ 66.169MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +4.7% ✅ exception-replay-enabledTime: ✅ 1.339ms (SLO: <1.450ms -7.7%) vs baseline: ~same Memory: ✅ 63.982MB (SLO: <67.000MB -4.5%) vs baseline: +4.9% ✅ iastTime: ✅ 20.372ms (SLO: <22.250ms -8.4%) vs baseline: -0.5% Memory: ✅ 66.126MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.561ms (SLO: <16.550ms -6.0%) vs baseline: -0.1% Memory: ✅ 54.096MB (SLO: <54.500MB 🟡 -0.7%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.557ms (SLO: <21.750ms -5.5%) vs baseline: ~same Memory: ✅ 66.144MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.409ms (SLO: <28.200ms -9.9%) vs baseline: -0.4% Memory: ✅ 67.184MB (SLO: <69.500MB -3.3%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.482ms (SLO: <21.750ms -5.8%) vs baseline: +0.2% Memory: ✅ 66.085MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.7% ✅ tracer-and-profilerTime: ✅ 22.650ms (SLO: <23.500ms -3.6%) vs baseline: +0.2% Memory: ✅ 67.865MB (SLO: <68.000MB 🟡 -0.2%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.226ms (SLO: <21.500ms 📉 -10.6%) vs baseline: ~same Memory: ✅ 66.169MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.598ms (SLO: <17.500ms -5.2%) vs baseline: -0.2% Memory: ✅ 66.175MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 20.422ms (SLO: <21.750ms -6.1%) vs baseline: +0.1% Memory: ✅ 67.605MB (SLO: <72.500MB -6.8%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.382ms (SLO: <19.650ms -6.5%) vs baseline: -0.4% Memory: ✅ 66.228MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ tracer-no-databasesTime: ✅ 18.741ms (SLO: <20.100ms -6.8%) vs baseline: -0.1% Memory: ✅ 66.155MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.131ms (SLO: <21.500ms -6.4%) vs baseline: +0.1% Memory: ✅ 66.187MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.248ms (SLO: <22.000ms -8.0%) vs baseline: ~same Memory: ✅ 66.253MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.1% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.019ms (SLO: <19.850ms -9.2%) vs baseline: ~same Memory: ✅ 66.128MB (SLO: <66.500MB 🟡 -0.6%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.102ms (SLO: <19.400ms -6.7%) vs baseline: +0.4% Memory: ✅ 66.065MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 17.994ms (SLO: <19.450ms -7.5%) vs baseline: -0.4% Memory: ✅ 65.992MB (SLO: <66.500MB 🟡 -0.8%) vs baseline: +5.2% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.067ms (SLO: <2.300ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 52.553MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 2.075ms (SLO: <2.250ms -7.8%) vs baseline: ~same Memory: ✅ 52.494MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.5% ✅ tracer-enabledTime: ✅ 2.068ms (SLO: <2.300ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 52.475MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.5% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.584ms (SLO: <4.750ms -3.5%) vs baseline: -0.9% Memory: ✅ 62.376MB (SLO: <65.000MB -4.0%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.613ms (SLO: <6.750ms -2.0%) vs baseline: -0.3% Memory: ✅ 62.178MB (SLO: <65.000MB -4.3%) vs baseline: +5.2% ✅ appsec-telemetryTime: ✅ 4.594ms (SLO: <4.750ms -3.3%) vs baseline: -0.4% Memory: ✅ 62.451MB (SLO: <65.000MB -3.9%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: -0.4% Memory: ✅ 45.382MB (SLO: <47.000MB -3.4%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: -0.6% Memory: ✅ 42.335MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +5.1% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -8.9%) vs baseline: ~same Memory: ✅ 46.476MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: -0.3% Memory: ✅ 52.721MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.351ms (SLO: <3.650ms -8.2%) vs baseline: -0.3% Memory: ✅ 52.716MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.348ms (SLO: <3.650ms -8.3%) vs baseline: -0.2% Memory: ✅ 54.234MB (SLO: <60.000MB -9.6%) vs baseline: +4.8% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 309.031ms (SLO: <320.950ms -3.7%) vs baseline: +0.2% Memory: ✅ 32.814MB (SLO: <34.500MB -4.9%) vs baseline: +4.8% ✅ deep-profiledTime: ✅ 327.628ms (SLO: <359.150ms -8.8%) vs baseline: -0.1% Memory: ✅ 38.332MB (SLO: <39.000MB 🟡 -1.7%) vs baseline: +6.6% ✅ mediumTime: ✅ 6.998ms (SLO: <7.400ms -5.4%) vs baseline: +0.2% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.1% ✅ shallowTime: ✅ 0.938ms (SLO: <1.050ms 📉 -10.7%) vs baseline: ~same Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.9% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.032µs (SLO: <20.000µs 📉 -84.8%) vs baseline: -1.6% Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 199.592µs (SLO: <220.000µs -9.3%) vs baseline: -1.7% Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.376µs (SLO: <20.000µs 📉 -83.1%) vs baseline: -0.8% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.3% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.902µs (SLO: <220.000µs -2.3%) vs baseline: -1.1% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.226µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -1.0% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +4.5% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.604µs (SLO: <150.000µs -8.9%) vs baseline: +0.2% Memory: ✅ 32.027MB (SLO: <34.000MB -5.8%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.191µs (SLO: <20.000µs 📉 -84.0%) vs baseline: -0.2% Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 213.821µs (SLO: <250.000µs 📉 -14.5%) vs baseline: -1.3% Memory: ✅ 32.027MB (SLO: <34.000MB -5.8%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.243ms (SLO: <22.000ms -8.0%) vs baseline: +2.4% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.261ms (SLO: <2.300ms 🟡 -1.7%) vs baseline: -1.0% Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.412ms (SLO: <1.550ms -8.9%) vs baseline: +1.2% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.192ms (SLO: <2.550ms 📉 -14.0%) vs baseline: +0.3% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.732µs (SLO: <20.000µs 📉 -76.3%) vs baseline: -0.1% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +5.1% ✅ flush-100-metricsTime: ✅ 177.127µs (SLO: <250.000µs 📉 -29.1%) vs baseline: ~same Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.124ms (SLO: <2.500ms 📉 -15.0%) vs baseline: -0.6% Memory: ✅ 32.834MB (SLO: <34.500MB -4.8%) vs baseline: +5.0%
|
emmettbutler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can go directly into main, doesn't need to hit 4.0-breaking-changes
Yeah, we can merge this later after merging 4.0-breaking-changes to main. On current main these files don't exist. They only exist on 4.0-breaking-changes branch. |
Description
Testing
Risks
Additional Notes