-
Notifications
You must be signed in to change notification settings - Fork 316
set unified service tags on llm obs span start #9935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
8439d19 to
f624996
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 4569fd7 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~4569fd7206, baseline=1.56.0-SNAPSHOT~29d5c2d641
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1103487
Total [baseline] (8.818 s) : 0, 8818287
Agent [candidate] (1.103 s) : 0, 1102718
Total [candidate] (8.813 s) : 0, 8813181
section iast
Agent [baseline] (1.233 s) : 0, 1233027
Total [baseline] (9.529 s) : 0, 9529309
Agent [candidate] (1.235 s) : 0, 1235065
Total [candidate] (9.536 s) : 0, 9535722
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~4569fd7206, baseline=1.56.0-SNAPSHOT~29d5c2d641
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (708.874 ms) : 0, 708874
BytebuddyAgent [candidate] (709.001 ms) : 0, 709001
GlobalTracer [baseline] (249.553 ms) : 0, 249553
GlobalTracer [candidate] (249.33 ms) : 0, 249330
AppSec [baseline] (32.556 ms) : 0, 32556
AppSec [candidate] (32.62 ms) : 0, 32620
Debugger [baseline] (63.658 ms) : 0, 63658
Debugger [candidate] (63.29 ms) : 0, 63290
Remote Config [baseline] (650.186 µs) : 0, 650
Remote Config [candidate] (631.587 µs) : 0, 632
Telemetry [baseline] (8.324 ms) : 0, 8324
Telemetry [candidate] (8.019 ms) : 0, 8019
Flare Poller [baseline] (3.702 ms) : 0, 3702
Flare Poller [candidate] (3.656 ms) : 0, 3656
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (827.112 ms) : 0, 827112
BytebuddyAgent [candidate] (828.192 ms) : 0, 828192
GlobalTracer [baseline] (236.85 ms) : 0, 236850
GlobalTracer [candidate] (237.482 ms) : 0, 237482
IAST [baseline] (27.493 ms) : 0, 27493
IAST [candidate] (29.131 ms) : 0, 29131
AppSec [baseline] (33.964 ms) : 0, 33964
AppSec [candidate] (32.388 ms) : 0, 32388
Debugger [baseline] (59.936 ms) : 0, 59936
Debugger [candidate] (60.138 ms) : 0, 60138
Remote Config [baseline] (543.767 µs) : 0, 544
Remote Config [candidate] (546.377 µs) : 0, 546
Telemetry [baseline] (7.616 ms) : 0, 7616
Telemetry [candidate] (7.662 ms) : 0, 7662
Flare Poller [baseline] (3.452 ms) : 0, 3452
Flare Poller [candidate] (3.463 ms) : 0, 3463
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~4569fd7206, baseline=1.56.0-SNAPSHOT~29d5c2d641
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1094413
Total [baseline] (10.722 s) : 0, 10721603
Agent [candidate] (1.101 s) : 0, 1100625
Total [candidate] (10.83 s) : 0, 10829925
section appsec
Agent [baseline] (1.279 s) : 0, 1278629
Total [baseline] (11.212 s) : 0, 11211676
Agent [candidate] (1.281 s) : 0, 1281475
Total [candidate] (11.102 s) : 0, 11101691
section iast
Agent [baseline] (1.237 s) : 0, 1237201
Total [baseline] (11.229 s) : 0, 11228744
Agent [candidate] (1.237 s) : 0, 1237269
Total [candidate] (11.197 s) : 0, 11197222
section profiling
Agent [baseline] (1.226 s) : 0, 1225740
Total [baseline] (11.013 s) : 0, 11013330
Agent [candidate] (1.237 s) : 0, 1236733
Total [candidate] (11.205 s) : 0, 11205123
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~4569fd7206, baseline=1.56.0-SNAPSHOT~29d5c2d641
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (702.686 ms) : 0, 702686
BytebuddyAgent [candidate] (706.137 ms) : 0, 706137
GlobalTracer [baseline] (247.063 ms) : 0, 247063
GlobalTracer [candidate] (248.515 ms) : 0, 248515
AppSec [baseline] (32.179 ms) : 0, 32179
AppSec [candidate] (32.573 ms) : 0, 32573
Debugger [baseline] (63.917 ms) : 0, 63917
Debugger [candidate] (64.515 ms) : 0, 64515
Remote Config [baseline] (665.297 µs) : 0, 665
Remote Config [candidate] (646.942 µs) : 0, 647
Telemetry [baseline] (8.205 ms) : 0, 8205
Telemetry [candidate] (8.369 ms) : 0, 8369
Flare Poller [baseline] (3.689 ms) : 0, 3689
Flare Poller [candidate] (3.804 ms) : 0, 3804
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (729.083 ms) : 0, 729083
BytebuddyAgent [candidate] (729.824 ms) : 0, 729824
GlobalTracer [baseline] (240.731 ms) : 0, 240731
GlobalTracer [candidate] (240.959 ms) : 0, 240959
AppSec [baseline] (173.795 ms) : 0, 173795
AppSec [candidate] (174.817 ms) : 0, 174817
Debugger [baseline] (61.137 ms) : 0, 61137
Debugger [candidate] (61.672 ms) : 0, 61672
Remote Config [baseline] (664.49 µs) : 0, 664
Remote Config [candidate] (690.179 µs) : 0, 690
Telemetry [baseline] (8.339 ms) : 0, 8339
Telemetry [candidate] (8.457 ms) : 0, 8457
Flare Poller [baseline] (3.966 ms) : 0, 3966
Flare Poller [candidate] (3.978 ms) : 0, 3978
IAST [baseline] (24.735 ms) : 0, 24735
IAST [candidate] (24.911 ms) : 0, 24911
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (829.421 ms) : 0, 829421
BytebuddyAgent [candidate] (829.18 ms) : 0, 829180
GlobalTracer [baseline] (237.697 ms) : 0, 237697
GlobalTracer [candidate] (238.002 ms) : 0, 238002
AppSec [baseline] (33.072 ms) : 0, 33072
AppSec [candidate] (33.919 ms) : 0, 33919
Debugger [baseline] (60.954 ms) : 0, 60954
Debugger [candidate] (60.983 ms) : 0, 60983
Remote Config [baseline] (534.969 µs) : 0, 535
Remote Config [candidate] (539.299 µs) : 0, 539
Telemetry [baseline] (7.615 ms) : 0, 7615
Telemetry [candidate] (7.651 ms) : 0, 7651
Flare Poller [baseline] (3.499 ms) : 0, 3499
Flare Poller [candidate] (3.488 ms) : 0, 3488
IAST [baseline] (28.264 ms) : 0, 28264
IAST [candidate] (27.406 ms) : 0, 27406
section profiling
ProfilingAgent [baseline] (97.127 ms) : 0, 97127
ProfilingAgent [candidate] (99.78 ms) : 0, 99780
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (728.669 ms) : 0, 728669
BytebuddyAgent [candidate] (734.84 ms) : 0, 734840
GlobalTracer [baseline] (221.28 ms) : 0, 221280
GlobalTracer [candidate] (222.374 ms) : 0, 222374
AppSec [baseline] (32.368 ms) : 0, 32368
AppSec [candidate] (32.259 ms) : 0, 32259
Debugger [baseline] (63.132 ms) : 0, 63132
Debugger [candidate] (63.766 ms) : 0, 63766
Remote Config [baseline] (647.634 µs) : 0, 648
Remote Config [candidate] (662.32 µs) : 0, 662
Telemetry [baseline] (7.97 ms) : 0, 7970
Telemetry [candidate] (8.037 ms) : 0, 8037
Flare Poller [baseline] (3.79 ms) : 0, 3790
Flare Poller [candidate] (3.811 ms) : 0, 3811
Profiling [baseline] (97.712 ms) : 0, 97712
Profiling [candidate] (100.379 ms) : 0, 100379
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~4569fd7206, baseline=1.56.0-SNAPSHOT~29d5c2d641
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.215 ms) : 3152, 3278
. : milestone, 3215,
iast_FULL (5.915 ms) : 5836, 5994
. : milestone, 5915,
iast_GLOBAL (3.729 ms) : 3623, 3835
. : milestone, 3729,
profiling (2.178 ms) : 2158, 2199
. : milestone, 2178,
tracing (1.831 ms) : 1816, 1846
. : milestone, 1831,
section candidate
no_agent (1.192 ms) : 1180, 1204
. : milestone, 1192,
iast (3.318 ms) : 3213, 3422
. : milestone, 3318,
iast_FULL (5.743 ms) : 5673, 5812
. : milestone, 5743,
iast_GLOBAL (3.467 ms) : 3419, 3515
. : milestone, 3467,
profiling (2.0 ms) : 1982, 2018
. : milestone, 2000,
tracing (1.817 ms) : 1802, 1833
. : milestone, 1817,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~4569fd7206, baseline=1.56.0-SNAPSHOT~29d5c2d641
dateFormat X
axisFormat %s
section baseline
no_agent (18.271 ms) : 18086, 18457
. : milestone, 18271,
appsec (18.673 ms) : 18482, 18863
. : milestone, 18673,
code_origins (17.62 ms) : 17444, 17795
. : milestone, 17620,
iast (18.286 ms) : 18101, 18471
. : milestone, 18286,
profiling (18.36 ms) : 18178, 18542
. : milestone, 18360,
tracing (17.495 ms) : 17323, 17668
. : milestone, 17495,
section candidate
no_agent (17.358 ms) : 17184, 17533
. : milestone, 17358,
appsec (18.776 ms) : 18584, 18969
. : milestone, 18776,
code_origins (18.01 ms) : 17831, 18189
. : milestone, 18010,
iast (17.71 ms) : 17532, 17888
. : milestone, 17710,
profiling (18.713 ms) : 18524, 18903
. : milestone, 18713,
tracing (17.687 ms) : 17511, 17862
. : milestone, 17687,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~4569fd7206, baseline=1.56.0-SNAPSHOT~29d5c2d641
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.713 ms) : 3496, 3930
. : milestone, 3713,
iast (2.204 ms) : 2141, 2268
. : milestone, 2204,
iast_GLOBAL (2.27 ms) : 2204, 2335
. : milestone, 2270,
profiling (2.078 ms) : 2024, 2131
. : milestone, 2078,
tracing (2.027 ms) : 1977, 2078
. : milestone, 2027,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.634 ms) : 3420, 3848
. : milestone, 3634,
iast (2.207 ms) : 2142, 2271
. : milestone, 2207,
iast_GLOBAL (2.259 ms) : 2195, 2323
. : milestone, 2259,
profiling (2.511 ms) : 2340, 2682
. : milestone, 2511,
tracing (2.027 ms) : 1976, 2077
. : milestone, 2027,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~4569fd7206, baseline=1.56.0-SNAPSHOT~29d5c2d641
dateFormat X
axisFormat %s
section baseline
no_agent (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
appsec (14.532 s) : 14532000, 14532000
. : milestone, 14532000,
iast (18.241 s) : 18241000, 18241000
. : milestone, 18241000,
iast_GLOBAL (18.031 s) : 18031000, 18031000
. : milestone, 18031000,
profiling (14.875 s) : 14875000, 14875000
. : milestone, 14875000,
tracing (14.78 s) : 14780000, 14780000
. : milestone, 14780000,
section candidate
no_agent (15.366 s) : 15366000, 15366000
. : milestone, 15366000,
appsec (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
iast (18.293 s) : 18293000, 18293000
. : milestone, 18293000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (15.127 s) : 15127000, 15127000
. : milestone, 15127000,
tracing (14.519 s) : 14519000, 14519000
. : milestone, 14519000,
|
dd-java-agent/agent-llmobs/src/main/java/datadog/trace/llmobs/domain/DDLLMObsSpan.java
Outdated
Show resolved
Hide resolved
dd-java-agent/agent-llmobs/src/main/java/datadog/trace/llmobs/domain/DDLLMObsSpan.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change need to be covered with tests?
yes, done! |
dd-java-agent/agent-llmobs/src/test/groovy/datadog/trace/llmobs/domain/DDLLMObsSpanTest.groovy
Outdated
Show resolved
Hide resolved
403f4f8 to
4569fd7
Compare
What Does This Do
when LLM Obs spans start, unified service tags are now attached automatically on the spans
tested by running a sample app locally with the following
meaning we should have
env:local,service:gary-test, andversion:4.20the resulting span (and its children spans) all have the UST tags as well as the tags added in the sample app

https://dddev.datadoghq.com/llm/traces?query=%40event_type%3Aspan%20%40parent_id%3Aundefined%20service%3Agary-test&agg_m=count&agg_m_source=base&agg_t=count&fromUser=true&sp=%5B%7B%22p%22%3A%7B%22eventId%22%3A%22AwAAAZp0yabX95MsMAAAABhBWnAweWFiWEFBQjd4M2hJOFVTNEFBQUEAAAAkMDE5YTc0YzktYTZkYS00MjQ5LTgwNDUtMTkwNjg2NWM1YWZkAAAAAw%22%7D%2C%22i%22%3A%22llm-obs-panel%22%7D%5D&spanId=6960426944522644278&start=1762894957239&end=1762898557239&paused=true
also searchable
https://dddev.datadoghq.com/llm/traces?query=%40event_type%3Aspan%20%40parent_id%3Aundefined%20service%3Agary-test&agg_m=count&agg_m_source=base&agg_t=count&fromUser=true&spanId=6960426944522644278&start=1762894957239&end=1762898557239&paused=true
https://dddev.datadoghq.com/llm/traces?query=%40event_type%3Aspan%20%40parent_id%3Aundefined%20env%3Alocal&agg_m=count&agg_m_source=base&agg_t=count&fromUser=true&spanId=6960426944522644278&start=1762894957239&end=1762898557239&paused=true
https://dddev.datadoghq.com/llm/traces?query=%40event_type%3Aspan%20%40parent_id%3Aundefined%20version%3A4.20&agg_m=count&agg_m_source=base&agg_t=count&fromUser=true&spanId=6960426944522644278&start=1762894957239&end=1762898557239&paused=true
Motivation
bug report fixes MLOS-291
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]