Skip to content

Commit 403f4f8

Browse files
gary-huanggary-huang
committed
dont need asserts in then
1 parent 3bdfe08 commit 403f4f8

File tree

1 file changed

+114
-114
lines changed

1 file changed

+114
-114
lines changed

‎dd-java-agent/agent-llmobs/src/test/groovy/datadog/trace/llmobs/domain/DDLLMObsSpanTest.groovy‎

Lines changed: 114 additions & 114 deletions
Original file line numberDiff line numberDiff line change
@@ -78,59 +78,59 @@ class DDLLMObsSpanTest extends DDSpecification{
7878

7979
then:
8080
def innerSpan = (AgentSpan)test.span
81-
assert Tags.LLMOBS_WORKFLOW_SPAN_KIND.equals(innerSpan.getTag(LLMOBS_TAG_PREFIX + "span.kind"))
81+
Tags.LLMOBS_WORKFLOW_SPAN_KIND.equals(innerSpan.getTag(LLMOBS_TAG_PREFIX + "span.kind"))
8282

83-
assert null == innerSpan.getTag("input")
84-
assert input.equals(innerSpan.getTag(INPUT))
85-
assert null == innerSpan.getTag("output")
86-
assert output.equals(innerSpan.getTag(OUTPUT))
83+
null == innerSpan.getTag("input")
84+
input.equals(innerSpan.getTag(INPUT))
85+
null == innerSpan.getTag("output")
86+
output.equals(innerSpan.getTag(OUTPUT))
8787

88-
assert null == innerSpan.getTag("metadata")
88+
null == innerSpan.getTag("metadata")
8989
def expectedMetadata = Maps.of("sport", "baseball", "price_data", Maps.of("gpt4", 100))
90-
assert expectedMetadata.equals(innerSpan.getTag(METADATA))
90+
expectedMetadata.equals(innerSpan.getTag(METADATA))
9191

92-
assert null == innerSpan.getTag("rank")
92+
null == innerSpan.getTag("rank")
9393
def rankMetric = innerSpan.getTag(LLMOBS_METRIC_PREFIX + "rank")
94-
assert rankMetric instanceof Number && 1 == (int)rankMetric
94+
rankMetric instanceof Number && 1 == (int)rankMetric
9595

96-
assert null == innerSpan.getTag("likelihood")
96+
null == innerSpan.getTag("likelihood")
9797
def likelihoodMetric = innerSpan.getTag(LLMOBS_METRIC_PREFIX + "likelihood")
98-
assert likelihoodMetric instanceof Number
99-
assert 0.1 == (double)likelihoodMetric
98+
likelihoodMetric instanceof Number
99+
0.1 == (double)likelihoodMetric
100100

101-
assert null == innerSpan.getTag("DOMAIN")
101+
null == innerSpan.getTag("DOMAIN")
102102
def domain = innerSpan.getTag(LLMOBS_TAG_PREFIX + "DOMAIN")
103-
assert domain instanceof String
104-
assert "north-america".equals((String)domain)
103+
domain instanceof String
104+
"north-america".equals((String)domain)
105105

106-
assert null == innerSpan.getTag("bulk1")
106+
null == innerSpan.getTag("bulk1")
107107
def tagBulk1 = innerSpan.getTag(LLMOBS_TAG_PREFIX + "bulk1")
108-
assert tagBulk1 instanceof Number
109-
assert 1 == ((int)tagBulk1)
108+
tagBulk1 instanceof Number
109+
1 == ((int)tagBulk1)
110110

111-
assert null == innerSpan.getTag("bulk2")
111+
null == innerSpan.getTag("bulk2")
112112
def tagBulk2 = innerSpan.getTag(LLMOBS_TAG_PREFIX + "bulk2")
113-
assert tagBulk2 instanceof String
114-
assert "2".equals((String)tagBulk2)
113+
tagBulk2 instanceof String
114+
"2".equals((String)tagBulk2)
115115

116-
assert innerSpan.isError()
117-
assert innerSpan.getTag(DDTags.ERROR_MSG) instanceof String
118-
assert errMsg.equals(innerSpan.getTag(DDTags.ERROR_MSG))
116+
innerSpan.isError()
117+
innerSpan.getTag(DDTags.ERROR_MSG) instanceof String
118+
errMsg.equals(innerSpan.getTag(DDTags.ERROR_MSG))
119119

120-
assert null == innerSpan.getTag("env")
120+
null == innerSpan.getTag("env")
121121
def tagEnv = innerSpan.getTag(LLMOBS_TAG_PREFIX + "env")
122-
assert tagEnv instanceof UTF8BytesString
123-
assert "test-env" == tagEnv.toString()
122+
tagEnv instanceof UTF8BytesString
123+
"test-env" == tagEnv.toString()
124124

125-
assert null == innerSpan.getTag("service")
125+
null == innerSpan.getTag("service")
126126
def tagSvc = innerSpan.getTag(LLMOBS_TAG_PREFIX + "service")
127-
assert tagSvc instanceof UTF8BytesString
128-
assert "test-svc" == tagSvc.toString()
127+
tagSvc instanceof UTF8BytesString
128+
"test-svc" == tagSvc.toString()
129129

130-
assert null == innerSpan.getTag("version")
130+
null == innerSpan.getTag("version")
131131
def tagVersion = innerSpan.getTag(LLMOBS_TAG_PREFIX + "version")
132-
assert tagVersion instanceof UTF8BytesString
133-
assert "v1" == tagVersion.toString()
132+
tagVersion instanceof UTF8BytesString
133+
"v1" == tagVersion.toString()
134134
}
135135

136136
def "test span with overwrites"() {
@@ -170,52 +170,52 @@ class DDLLMObsSpanTest extends DDSpecification{
170170

171171
then:
172172
def innerSpan = (AgentSpan)test.span
173-
assert Tags.LLMOBS_AGENT_SPAN_KIND.equals(innerSpan.getTag(LLMOBS_TAG_PREFIX + "span.kind"))
173+
Tags.LLMOBS_AGENT_SPAN_KIND.equals(innerSpan.getTag(LLMOBS_TAG_PREFIX + "span.kind"))
174174

175-
assert null == innerSpan.getTag("input")
176-
assert input.equals(innerSpan.getTag(INPUT))
177-
assert null == innerSpan.getTag("output")
178-
assert expectedOutput.equals(innerSpan.getTag(OUTPUT))
175+
null == innerSpan.getTag("input")
176+
input.equals(innerSpan.getTag(INPUT))
177+
null == innerSpan.getTag("output")
178+
expectedOutput.equals(innerSpan.getTag(OUTPUT))
179179

180-
assert null == innerSpan.getTag("metadata")
180+
null == innerSpan.getTag("metadata")
181181
def expectedMetadata = Maps.of("sport", "hockey", "price_data", Maps.of("gpt4", 100), "temperature", 30)
182-
assert expectedMetadata.equals(innerSpan.getTag(METADATA))
182+
expectedMetadata.equals(innerSpan.getTag(METADATA))
183183

184-
assert null == innerSpan.getTag("rank")
184+
null == innerSpan.getTag("rank")
185185
def rankMetric = innerSpan.getTag(LLMOBS_METRIC_PREFIX + "rank")
186-
assert rankMetric instanceof Number && 10 == (int)rankMetric
186+
rankMetric instanceof Number && 10 == (int)rankMetric
187187

188-
assert null == innerSpan.getTag("DOMAIN")
188+
null == innerSpan.getTag("DOMAIN")
189189
def domain = innerSpan.getTag(LLMOBS_TAG_PREFIX + "DOMAIN")
190-
assert domain instanceof String
191-
assert "europe".equals((String)domain)
190+
domain instanceof String
191+
"europe".equals((String)domain)
192192

193-
assert null == innerSpan.getTag("bulk1")
193+
null == innerSpan.getTag("bulk1")
194194
def tagBulk1 = innerSpan.getTag(LLMOBS_TAG_PREFIX + "bulk1")
195-
assert tagBulk1 instanceof Number
196-
assert 1 == ((int)tagBulk1)
195+
tagBulk1 instanceof Number
196+
1 == ((int)tagBulk1)
197197

198-
assert !innerSpan.isError()
199-
assert innerSpan.getTag(DDTags.ERROR_MSG) instanceof String
200-
assert throwableMsg.equals(innerSpan.getTag(DDTags.ERROR_MSG))
201-
assert innerSpan.getTag(DDTags.ERROR_STACK) instanceof String
202-
assert ((String)innerSpan.getTag(DDTags.ERROR_STACK)).contains(throwableMsg)
198+
!innerSpan.isError()
199+
innerSpan.getTag(DDTags.ERROR_MSG) instanceof String
200+
throwableMsg.equals(innerSpan.getTag(DDTags.ERROR_MSG))
201+
innerSpan.getTag(DDTags.ERROR_STACK) instanceof String
202+
((String)innerSpan.getTag(DDTags.ERROR_STACK)).contains(throwableMsg)
203203

204204

205-
assert null == innerSpan.getTag("env")
205+
null == innerSpan.getTag("env")
206206
def tagEnv = innerSpan.getTag(LLMOBS_TAG_PREFIX + "env")
207-
assert tagEnv instanceof UTF8BytesString
208-
assert "test-env" == tagEnv.toString()
207+
tagEnv instanceof UTF8BytesString
208+
"test-env" == tagEnv.toString()
209209

210-
assert null == innerSpan.getTag("service")
210+
null == innerSpan.getTag("service")
211211
def tagSvc = innerSpan.getTag(LLMOBS_TAG_PREFIX + "service")
212-
assert tagSvc instanceof UTF8BytesString
213-
assert "test-svc" == tagSvc.toString()
212+
tagSvc instanceof UTF8BytesString
213+
"test-svc" == tagSvc.toString()
214214

215-
assert null == innerSpan.getTag("version")
215+
null == innerSpan.getTag("version")
216216
def tagVersion = innerSpan.getTag(LLMOBS_TAG_PREFIX + "version")
217-
assert tagVersion instanceof UTF8BytesString
218-
assert "v1" == tagVersion.toString()
217+
tagVersion instanceof UTF8BytesString
218+
"v1" == tagVersion.toString()
219219
}
220220

221221
def "test llm span string input formatted to messages"() {
@@ -230,43 +230,43 @@ class DDLLMObsSpanTest extends DDSpecification{
230230

231231
then:
232232
def innerSpan = (AgentSpan)test.span
233-
assert Tags.LLMOBS_LLM_SPAN_KIND.equals(innerSpan.getTag(LLMOBS_TAG_PREFIX + "span.kind"))
233+
Tags.LLMOBS_LLM_SPAN_KIND.equals(innerSpan.getTag(LLMOBS_TAG_PREFIX + "span.kind"))
234234

235-
assert null == innerSpan.getTag("input")
235+
null == innerSpan.getTag("input")
236236
def spanInput = innerSpan.getTag(INPUT)
237-
assert spanInput instanceof List
238-
assert ((List)spanInput).size() == 1
239-
assert spanInput.get(0) instanceof LLMObs.LLMMessage
237+
spanInput instanceof List
238+
((List)spanInput).size() == 1
239+
spanInput.get(0) instanceof LLMObs.LLMMessage
240240
def expectedInputMsg = LLMObs.LLMMessage.from("unknown", input)
241-
assert expectedInputMsg.getContent().equals(input)
242-
assert expectedInputMsg.getRole().equals("unknown")
243-
assert expectedInputMsg.getToolCalls().equals(null)
241+
expectedInputMsg.getContent().equals(input)
242+
expectedInputMsg.getRole().equals("unknown")
243+
expectedInputMsg.getToolCalls().equals(null)
244244

245-
assert null == innerSpan.getTag("output")
245+
null == innerSpan.getTag("output")
246246
def spanOutput = innerSpan.getTag(OUTPUT)
247-
assert spanOutput instanceof List
248-
assert ((List)spanOutput).size() == 1
249-
assert spanOutput.get(0) instanceof LLMObs.LLMMessage
247+
spanOutput instanceof List
248+
((List)spanOutput).size() == 1
249+
spanOutput.get(0) instanceof LLMObs.LLMMessage
250250
def expectedOutputMsg = LLMObs.LLMMessage.from("unknown", output)
251-
assert expectedOutputMsg.getContent().equals(output)
252-
assert expectedOutputMsg.getRole().equals("unknown")
253-
assert expectedOutputMsg.getToolCalls().equals(null)
251+
expectedOutputMsg.getContent().equals(output)
252+
expectedOutputMsg.getRole().equals("unknown")
253+
expectedOutputMsg.getToolCalls().equals(null)
254254

255255

256-
assert null == innerSpan.getTag("env")
256+
null == innerSpan.getTag("env")
257257
def tagEnv = innerSpan.getTag(LLMOBS_TAG_PREFIX + "env")
258-
assert tagEnv instanceof UTF8BytesString
259-
assert "test-env" == tagEnv.toString()
258+
tagEnv instanceof UTF8BytesString
259+
"test-env" == tagEnv.toString()
260260

261-
assert null == innerSpan.getTag("service")
261+
null == innerSpan.getTag("service")
262262
def tagSvc = innerSpan.getTag(LLMOBS_TAG_PREFIX + "service")
263-
assert tagSvc instanceof UTF8BytesString
264-
assert "test-svc" == tagSvc.toString()
263+
tagSvc instanceof UTF8BytesString
264+
"test-svc" == tagSvc.toString()
265265

266-
assert null == innerSpan.getTag("version")
266+
null == innerSpan.getTag("version")
267267
def tagVersion = innerSpan.getTag(LLMOBS_TAG_PREFIX + "version")
268-
assert tagVersion instanceof UTF8BytesString
269-
assert "v1" == tagVersion.toString()
268+
tagVersion instanceof UTF8BytesString
269+
"v1" == tagVersion.toString()
270270
}
271271

272272
def "test llm span with messages"() {
@@ -281,48 +281,48 @@ class DDLLMObsSpanTest extends DDSpecification{
281281

282282
then:
283283
def innerSpan = (AgentSpan)test.span
284-
assert Tags.LLMOBS_LLM_SPAN_KIND.equals(innerSpan.getTag(LLMOBS_TAG_PREFIX + "span.kind"))
284+
Tags.LLMOBS_LLM_SPAN_KIND.equals(innerSpan.getTag(LLMOBS_TAG_PREFIX + "span.kind"))
285285

286-
assert null == innerSpan.getTag("input")
286+
null == innerSpan.getTag("input")
287287
def spanInput = innerSpan.getTag(INPUT)
288-
assert spanInput instanceof List
289-
assert ((List)spanInput).size() == 1
288+
spanInput instanceof List
289+
((List)spanInput).size() == 1
290290
def spanInputMsg = spanInput.get(0)
291-
assert spanInputMsg instanceof LLMObs.LLMMessage
292-
assert spanInputMsg.getContent().equals(inputMsg.getContent())
293-
assert spanInputMsg.getRole().equals("user")
294-
assert spanInputMsg.getToolCalls().equals(null)
291+
spanInputMsg instanceof LLMObs.LLMMessage
292+
spanInputMsg.getContent().equals(inputMsg.getContent())
293+
spanInputMsg.getRole().equals("user")
294+
spanInputMsg.getToolCalls().equals(null)
295295

296-
assert null == innerSpan.getTag("output")
296+
null == innerSpan.getTag("output")
297297
def spanOutput = innerSpan.getTag(OUTPUT)
298-
assert spanOutput instanceof List
299-
assert ((List)spanOutput).size() == 1
298+
spanOutput instanceof List
299+
((List)spanOutput).size() == 1
300300
def spanOutputMsg = spanOutput.get(0)
301-
assert spanOutputMsg instanceof LLMObs.LLMMessage
302-
assert spanOutputMsg.getContent().equals(outputMsg.getContent())
303-
assert spanOutputMsg.getRole().equals("assistant")
304-
assert spanOutputMsg.getToolCalls().size() == 1
301+
spanOutputMsg instanceof LLMObs.LLMMessage
302+
spanOutputMsg.getContent().equals(outputMsg.getContent())
303+
spanOutputMsg.getRole().equals("assistant")
304+
spanOutputMsg.getToolCalls().size() == 1
305305
def toolCall = spanOutputMsg.getToolCalls().get(0)
306-
assert toolCall.getName().equals("weather-tool")
307-
assert toolCall.getType().equals("function")
308-
assert toolCall.getToolId().equals("6176241000")
306+
toolCall.getName().equals("weather-tool")
307+
toolCall.getType().equals("function")
308+
toolCall.getToolId().equals("6176241000")
309309
def expectedToolArgs = Maps.of("location", "paris")
310-
assert toolCall.getArguments().equals(expectedToolArgs)
310+
toolCall.getArguments().equals(expectedToolArgs)
311311

312-
assert null == innerSpan.getTag("env")
312+
null == innerSpan.getTag("env")
313313
def tagEnv = innerSpan.getTag(LLMOBS_TAG_PREFIX + "env")
314-
assert tagEnv instanceof UTF8BytesString
315-
assert "test-env" == tagEnv.toString()
314+
tagEnv instanceof UTF8BytesString
315+
"test-env" == tagEnv.toString()
316316

317-
assert null == innerSpan.getTag("service")
317+
null == innerSpan.getTag("service")
318318
def tagSvc = innerSpan.getTag(LLMOBS_TAG_PREFIX + "service")
319-
assert tagSvc instanceof UTF8BytesString
320-
assert "test-svc" == tagSvc.toString()
319+
tagSvc instanceof UTF8BytesString
320+
"test-svc" == tagSvc.toString()
321321

322-
assert null == innerSpan.getTag("version")
322+
null == innerSpan.getTag("version")
323323
def tagVersion = innerSpan.getTag(LLMOBS_TAG_PREFIX + "version")
324-
assert tagVersion instanceof UTF8BytesString
325-
assert "v1" == tagVersion.toString()
324+
tagVersion instanceof UTF8BytesString
325+
"v1" == tagVersion.toString()
326326
}
327327

328328
private LLMObsSpan givenALLMObsSpan(String kind, name){

0 commit comments

Comments
 (0)