[refactor] Unify Cloud/OSS Missing Nodes modal #6673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viva-jinyi
requested review from
a team,
KarryCharon,
Yorha4D,
christian-byrne,
ltdrdata and
shinshin86
as code owners
dosubot
bot
added
the
size:L
🎭 Playwright Test Results⏰ Completed at: 11/15/2025, 06:24:56 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/15/2025, 06:14:31 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 2.98 MB (baseline 2.98 MB) • 🟢 -3.19 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 803 kB (baseline 803 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.03 kB (baseline 8.03 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 307 kB (baseline 307 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 210 kB (baseline 210 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 3 added / 3 removed Utilities & Hooks — 5.87 kB (baseline 5.87 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • 🟢 -10 BExternal libraries and shared vendor chunks
Status: 3 added / 3 removed Other — 3.92 MB (baseline 3.92 MB) • ⚪ 0 BBundles that do not match a named category
Status: 15 added / 15 removed |
viva-jinyi
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
bot
removed
the
New Browser Test Expectations
viva-jinyi
added
the
New Browser Test Expectations
github-actions
bot
removed
the
New Browser Test Expectations
DrJKL
reviewed
Nov 14, 2025
Contributor
|
Thank you 😁 |
viva-jinyi
force-pushed
the
feature/missing-node-modal-intergration
branch
3 times, most recently
from
fceb62d to
a297519
Compare
- Merged separate Cloud and OSS workflow warning modals into single unified modal - Removed legacy LoadWorkflowWarning.vue - Renamed CloudMissingNodes* components to MissingNodes* for clarity - Environment branching now handled internally via isCloud flag - Restructured i18n: removed loadWorkflowWarning, added missingNodes.cloud/oss sections - Improved OSS button styling to match Cloud consistency using TextButton Key changes: - OSS: 'Open Manager' + 'Install All' buttons - Cloud: 'Learn More' + 'Got It' buttons (unchanged) - Single unified modal displays different UI/text based on environment 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
viva-jinyi
force-pushed
the
feature/missing-node-modal-intergration
branch
from
ed8ac94 to
55b74e9
Compare
DrJKL
approved these changes
Nov 15, 2025
Member
Author
|
@Comfy-Org/comfy_frontend_devs Can someone approve this? |
viva-jinyi
added
the
needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
📝 Note on File Renames
This PR renames the following files:
CloudMissingNodesHeader.vue→MissingNodesHeader.vue(R053, 53% similarity)CloudMissingNodesContent.vue→MissingNodesContent.vue(R067, 67% similarity)LoadWorkflowWarning.vue→MissingNodesFooter.vue(R051, 51% similarity)CloudMissingNodesFooter.vue→ Deleted (replaced by new MissingNodesFooter)Why GitHub PR UI doesn't show renames properly:
GitHub detects renames only when file similarity is above 70%. In this PR, the Cloud/OSS unification significantly modified file contents, resulting in 51-67% similarity.
However, Git history correctly records these as renames. You can verify with:
While GitHub UI shows "additions/deletions", these are actually rename + modification operations.
Test Plan
missingnodes.webm
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito