refactor: cloud prefix removed & apply code review

Author: viva-jinyi

src/components/button/IconTextButton.vue

@@ -32,7 +32,7 @@ defineOptions({
 interface IconTextButtonProps extends BaseButtonProps {
   iconPosition?: 'left' | 'right'
   label: string
-  onClick: () => void
+  onClick?: () => void
 }
 
 const {

src/components/dialog/content/MissingCoreNodesMessage.vue

@@ -49,14 +49,14 @@ import { computed } from 'vue'
 import type { LGraphNode } from '@/lib/litegraph/src/litegraph'
 import { useSystemStatsStore } from '@/stores/systemStatsStore'
 
-const props = defineProps<{
+const { missingCoreNodes } = defineProps<{
   missingCoreNodes: Record<string, LGraphNode[]>
 }>()
 
 const systemStatsStore = useSystemStatsStore()
 
 const hasMissingCoreNodes = computed(() => {
-  return Object.keys(props.missingCoreNodes).length > 0
+  return Object.keys(missingCoreNodes).length > 0
 })
 
 // Use computed for reactive version tracking
@@ -66,7 +66,7 @@ const currentComfyUIVersion = computed<string | null>(() => {
 })
 
 const sortedMissingCoreNodes = computed(() => {
-  return Object.entries(props.missingCoreNodes).sort(([a], [b]) => {
+  return Object.entries(missingCoreNodes).sort(([a], [b]) => {
     // Sort by version in descending order (newest first)
     return compare(b, a) // Reversed for descending order
   })

src/components/dialog/content/MissingNodesContent.vue

@@ -13,10 +13,7 @@
           }}
         </p>
       </div>
-      <MissingCoreNodesMessage
-        v-if="!isCloud"
-        :missing-core-nodes="missingCoreNodes"
-      />
+      <MissingCoreNodesMessage v-if="!isCloud" :missing-core-nodes />
 
       <!-- Missing Nodes List Wrapper -->
       <div

src/components/dialog/content/MissingNodesFooter.vue

@@ -9,7 +9,10 @@
       type="transparent"
       size="sm"
       icon-position="left"
-      @click="handleLearnMoreClick"
+      as="a"
+      href="https://www.comfy.org/cloud"
+      target="_blank"
+      rel="noopener noreferrer"
     >
       <template #icon>
         <i class="icon-[lucide--info]"></i>
@@ -67,16 +70,10 @@ import { ManagerTab } from '@/workbench/extensions/manager/types/comfyManagerTyp
 const dialogStore = useDialogStore()
 const { t } = useI18n()
 
-// Cloud mode handlers
-const handleLearnMoreClick = () => {
-  window.open('https://www.comfy.org/cloud', '_blank')
-}
-
 const handleGotItClick = () => {
-  dialogStore.closeDialog({ key: 'global-cloud-missing-nodes' })
+  dialogStore.closeDialog({ key: 'global-missing-nodes' })
 }
 
-// OSS mode logic
 const { missingNodePacks, isLoading, error } = useMissingNodes()
 const comfyManagerStore = useComfyManagerStore()
 const managerState = useManagerState()
@@ -121,7 +118,7 @@ watch(allMissingNodesInstalled, async (allInstalled) => {
     // Use nextTick to ensure state updates are complete
     await nextTick()
 
-    dialogStore.closeDialog({ key: 'global-cloud-missing-nodes' })
+    dialogStore.closeDialog({ key: 'global-missing-nodes' })
 
     // Show success toast
     useToastStore().add({

src/services/dialogService.ts

@@ -51,7 +51,7 @@ export const useDialogService = () => {
     props: ComponentProps<typeof MissingNodesContent>
   ) {
     dialogStore.showDialog({
-      key: 'global-cloud-missing-nodes',
+      key: 'global-missing-nodes',
       headerComponent: MissingNodesHeader,
       footerComponent: MissingNodesFooter,
       component: MissingNodesContent,