Manchester | 25-ITP-Sep | Ahmad Hmedan | Sprint 1 | Sprint1 Coureswork #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmadHmedann
added
the
Needs Review
LonMcGregor
removed
the
Needs Review
LonMcGregor
reviewed
Oct 15, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Sprint-1/1-key-exercises/3-paths.js
Outdated
|
|
||
| const dir = ; | ||
| const ext = ; | ||
| const dir =filePath.substring(1,lastSlashIndex) ; |
There was a problem hiding this comment.
Look at the diagram in the comments - are you capturing the full part of the dir?
LonMcGregor
added
the
Reviewed
AhmadHmedann
added
Needs Review
Updated comment to clarify the format of movie length.
|
Great work on this sprint, it's done now |
LonMcGregor
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have done all the tasks in Sprint 1 coursework.
Questions
I don't have any.