Skip to content
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a318e04
called a function , interpreted the error message
alexandru-pocovnicu Oct 3, 2025
686be02
fixed the code to log the function and not the parameter
alexandru-pocovnicu Oct 3, 2025
763574c
fixed the function to return the square of a number by replacing the …
alexandru-pocovnicu Oct 3, 2025
f7173fc
replaced console.log with return inside the function
alexandru-pocovnicu Oct 3, 2025
9bfd01a
removed the semicolon after the "return" and moved "a+b" on the same …
alexandru-pocovnicu Oct 3, 2025
58fda13
removed unused code and updated the parameter
alexandru-pocovnicu Oct 3, 2025
0b055f8
implemented a function that calculates bmi with one decimal
alexandru-pocovnicu Oct 3, 2025
b9c50c9
implemented a function that turns a string in to snake uppercase
alexandru-pocovnicu Oct 3, 2025
e02e2e7
updated the function to replace all the spaces between words with"_"
alexandru-pocovnicu Oct 3, 2025
e9b8d94
created a function that converts pence in to pounds
alexandru-pocovnicu Oct 3, 2025
57ad058
added comments to answer the questions
alexandru-pocovnicu Oct 3, 2025
c688a68
wrote test cases for edge cases and updated the function accordingly
alexandru-pocovnicu Oct 3, 2025
6aa1613
fix: add space for readability in time formatting condition
alexandru-pocovnicu Oct 3, 2025
ad3dfa9
style: format code for consistency and readability
alexandru-pocovnicu Oct 20, 2025
b2a5048
refactor: simplify BMI calculation by removing unnecessary string con…
alexandru-pocovnicu Oct 20, 2025
b2684a1
fix: correct time formatting logic for midnight and noon cases
alexandru-pocovnicu Oct 20, 2025
dab924b
fix: update password validation logic
alexandru-pocovnicu Oct 23, 2025
9c73a1c
fix: ensure BMI result is returned as a number
alexandru-pocovnicu Oct 24, 2025
03018e6
fix: correct comparison operators and format output for consistency i…
alexandru-pocovnicu Oct 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Sprint-2/1-key-errors/0.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Predict and explain first...
// =============> write your prediction here
// we can not declare a variable which has the same name as the parameter, we will get a SyntaxError

// call the function capitalise with a string input
// interpret the error message and figure out why an error is occurring
Expand All @@ -8,6 +8,7 @@ function capitalise(str) {
let str = `${str[0].toUpperCase()}${str.slice(1)}`;
return str;
}
console.log(capitalise("hello"))

// =============> write your explanation here
// =============> write your new code here
// we are getting an error because of the way the function was wrote, "str" is the part that is causing the issue
// we can not declare a variable which has the same name as the parameter
23 changes: 15 additions & 8 deletions Sprint-2/1-key-errors/1.js
Original file line number Diff line number Diff line change
@@ -1,20 +1,27 @@
// Predict and explain first...

// Why will an error occur when this program runs?
// =============> write your prediction here
// decimalNumber is already used as a parameter so it can not be used as a variable inside the function,
// the code is logging the parameter instead of the function

// Try playing computer with the example to work out what is going on

// function convertToPercentage(decimalNumber) {
// const decimalNumber = 0.5;
// const percentage = `${decimalNumber * 100}%`;

// return percentage;
// }

// console.log(decimalNumber);

// I'm not sure about what to write here

// Finally, correct the code to fix the problem
function convertToPercentage(decimalNumber) {
const decimalNumber = 0.5;
const percentage = `${decimalNumber * 100}%`;

return percentage;
}

console.log(decimalNumber);

// =============> write your explanation here

// Finally, correct the code to fix the problem
// =============> write your new code here
console.log(convertToPercentage(0.9))
25 changes: 18 additions & 7 deletions Sprint-2/1-key-errors/2.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,29 @@

// this function should square any number but instead we're going to get an error

// =============> write your prediction of the error here
// undefined, because "num" isn't used as a parameter

function square(3) {
return num * num;
}
// function square(3) {
// return num * num;
// }

// /Users/cyf/Desktop/CYF/Module-Structuring-and-Testing-Data/Sprint-2/1-key-errors/2.js:8
// function square(3) {
// ^

// =============> write the error message here
// SyntaxError: Unexpected number

// =============> explain this error message here

// the first line tells us where the error occurs:root,folder,file,line
//second line shows exactly which piece of code throws the error
//third line tells us which type of error it is, in this case it is a SyntaxError, meaning that the code wasnt written according to the rules of js,
//an finally it tells us what went wrong

// Finally, correct the code to fix the problem

// =============> write your new code here
function square(num) {
return num * num;
}

console.log(square(3));

18 changes: 11 additions & 7 deletions Sprint-2/2-mandatory-debug/0.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
// Predict and explain first...

// =============> write your prediction here
// the function hasn't got a return so the log will be undefined

function multiply(a, b) {
console.log(a * b);
}
// function multiply(a, b) {
// console.log(a * b);
// }

console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`);
// console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`);

// =============> write your explanation here
// the function hasn't got a return so the log will be undefined

// Finally, correct the code to fix the problem
// =============> write your new code here
function multiply(a, b) {
return a * b;
}

console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`);
19 changes: 12 additions & 7 deletions Sprint-2/2-mandatory-debug/1.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
// Predict and explain first...
// =============> write your prediction here
// SyntaxError

// function sum(a, b) {
// return;
// a + b;
// }

// console.log(`The sum of 10 and 32 is ${sum(10, 32)}`);

// the function doesn't return anything because there is ";" immediately after "return" and the mathematicall operation is on another line
// Finally, correct the code to fix the problem
function sum(a, b) {
return;
a + b;
return a + b;

}

console.log(`The sum of 10 and 32 is ${sum(10, 32)}`);

// =============> write your explanation here
// Finally, correct the code to fix the problem
// =============> write your new code here
29 changes: 19 additions & 10 deletions Sprint-2/2-mandatory-debug/2.js
Original file line number Diff line number Diff line change
@@ -1,24 +1,33 @@
// Predict and explain first...

// Predict the output of the following code:
// =============> Write your prediction here
// num undefined

const num = 103;
// const num = 103;

function getLastDigit() {
// function getLastDigit() {
// return num.toString().slice(-1);
// }

// console.log(`The last digit of 42 is ${getLastDigit(42)}`);
// console.log(`The last digit of 105 is ${getLastDigit(105)}`);
// console.log(`The last digit of 806 is ${getLastDigit(806)}`);

// Now run the code and compare the output to your prediction
// The last digit of 42 is 3
// The last digit of 105 is 3
// The last digit of 806 is 3

// Explain why the output is the way it is
// because num is declared as a global variable and it never changes, should be used as parameter
// Finally, correct the code to fix the problem
function getLastDigit(num) {
return num.toString().slice(-1);
}

console.log(`The last digit of 42 is ${getLastDigit(42)}`);
console.log(`The last digit of 105 is ${getLastDigit(105)}`);
console.log(`The last digit of 806 is ${getLastDigit(806)}`);

// Now run the code and compare the output to your prediction
// =============> write the output here
// Explain why the output is the way it is
// =============> write your explanation here
// Finally, correct the code to fix the problem
// =============> write your new code here

// This program should tell the user the last digit of each number.
// Explain why getLastDigit is not working properly - correct the problem
8 changes: 6 additions & 2 deletions Sprint-2/3-mandatory-implement/1-bmi.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,9 @@
// It should return their Body Mass Index to 1 decimal place

function calculateBMI(weight, height) {
// return the BMI of someone based off their weight and height
}
let sqh = height * height;
let bmi = weight / sqh;

return bmi.toFixed(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it returns a number , but the requrements don't specify should return

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the value of bmi.toFixed(1) a number or a string? They may "look" the same when we use console.log() to output them on the screen, but internally they are represented differently.

The spec does not specify what type of value the function should return, but what is your expectation? I am just concern if your code matches your expectation or not.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right , i was expecting the function to return a number, didn't realise .toFixed() turned it in to a string

}
console.log(calculateBMI(20, 1.79));
7 changes: 7 additions & 0 deletions Sprint-2/3-mandatory-implement/2-cases.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,10 @@
// You will need to come up with an appropriate name for the function
// Use the MDN string documentation to help you find a solution
// This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase

function convertToSnakeUpperCase(str){
// const upper=str.toUpperCase();
// const snake=upper.replace(" ","_");
return str.toUpperCase().replaceAll(" ", "_");
}
console.log(convertToSnakeUpperCase("hello there buddy"));
20 changes: 20 additions & 0 deletions Sprint-2/3-mandatory-implement/3-to-pounds.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,23 @@
// You will need to declare a function called toPounds with an appropriately named parameter.

// You should call this function a number of times to check it works for different inputs
//const penceString = "399p";
function toPounds(penceString) {
const penceStringWithoutTrailingP = penceString.substring(
0,
penceString.length - 1
);
const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
const pounds = paddedPenceNumberString.substring(
0,
paddedPenceNumberString.length - 2
);
const pence = paddedPenceNumberString
.substring(paddedPenceNumberString.length - 2)
.padEnd(2, "0");
return `${pounds}.${pence}`;
}
console.log(toPounds("399p"));
console.log(toPounds("23354p"));
console.log(toPounds("39p"));
console.log(toPounds("9p"));
12 changes: 7 additions & 5 deletions Sprint-2/4-mandatory-interpret/time-format.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,20 @@ function formatTimeDisplay(seconds) {
// Questions

// a) When formatTimeDisplay is called how many times will pad be called?
// =============> write your answer here
// 3 times

// Call formatTimeDisplay with an input of 61, now answer the following:

// b) What is the value assigned to num when pad is called for the first time?
// =============> write your answer here
// 0

// c) What is the return value of pad is called for the first time?
// =============> write your answer here
// "00"

// d) What is the value assigned to num when pad is called for the last time in this program? Explain your answer
// =============> write your answer here
// 1,because remainingSeconds=1

// e) What is the return value assigned to num when pad is called for the last time in this program? Explain your answer
// =============> write your answer here
// "01",remainingSeconds.toString().padStart(2, "0");


40 changes: 39 additions & 1 deletion Sprint-2/5-stretch-extend/format-time.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@

function formatAs12HourClock(time) {
const hours = Number(time.slice(0, 2));
const minutes=time.slice(3,5)
if(hours===0){
return `12:${minutes} am`
}
if(hours===12 ){
return `${hours}:${minutes} pm`
}
if (hours > 12) {
return `${hours - 12}:00 pm`;
return `${hours - 12}:${minutes} pm`;
}
return `${time} am`;
}
Expand All @@ -23,3 +30,34 @@ console.assert(
currentOutput2 === targetOutput2,
`current output: ${currentOutput2}, target output: ${targetOutput2}`
);

const currentOutput3 = formatAs12HourClock("23:33");
const targetOutput3 = "11:33 pm";
console.assert(
currentOutput3 === targetOutput3,
`current output: ${currentOutput3}, target output: ${targetOutput3}`
);

const currentOutput4 = formatAs12HourClock("11:59");
const targetOutput4 = "11:59 am";
console.assert(
currentOutput4 === targetOutput4,
`current output: ${currentOutput4}, target output: ${targetOutput4}`
);

const currentOutput5 = formatAs12HourClock("00:01");
const targetOutput5 = "12:01 am";
console.assert(
currentOutput5 === targetOutput5,
`current output: ${currentOutput5}, target output: ${targetOutput5}`
);

const currentOutput6 = formatAs12HourClock("12:59");
const targetOutput6 = "12:59 pm";
console.assert(
currentOutput6 === targetOutput6,
`current output: ${currentOutput6}, target output: ${targetOutput6}`
);