London | 25-ITP-May | Alexandru Pocovnicu | Sprint 2 | Acoursework #728

alexandru-pocovnicu · 2025-10-03T19:51:50Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

In this pill request I have fixed errors, interpreted and implemented code

Questions

…parameter

…line with"return" otherwise a semicolon would be automatically inserted

Sprint-2/3-mandatory-implement/1-bmi.js

cjyuan · 2025-10-12T20:48:00Z

Sprint-2/5-stretch-extend/format-time.js

+  if(hours<1){
+    return `12:${minutes} am`
+  }
+  if(hours==12 && minutes==00){
+    return "12:00 pm"
+  }
  if (hours > 12) {
-    return `${hours - 12}:00 pm`;
+    return `${hours - 12}:${minutes} pm`;
  }
  return `${time} am`;
 }


Because hours won't be negative, if (hours == 0) would probably be more readable than if (hours < 1).

What is the 12-hour clock equivalent of 24-hour clock time "12:59"?

What do you expect from the following function calls? Are the return values formatted consistently?

formatAs12HourClock("01:33"); formatAs12HourClock("13:33");

12:59 pm

1:33 am

1:33 pm

Did your function return the values you expect from these function calls?

formatAs12HourClock("01:33");` formatAs12HourClock("13:33");

i got 01:33 am
and 1:33 pm
I think that's right

"01:33 am" is not quite the same as "1:33 am".

…version

alexandru-pocovnicu · 2025-10-20T20:43:29Z

thank you

cjyuan · 2025-10-20T20:52:37Z

Sprint-2/3-mandatory-implement/1-bmi.js

+  let sqh = height * height;
+  let bmi = weight / sqh;
+
+  return bmi.toFixed(1);


What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect?

it returns a number , but the requrements don't specify should return

Is the value of bmi.toFixed(1) a number or a string? They may "look" the same when we use console.log() to output them on the screen, but internally they are represented differently.

The spec does not specify what type of value the function should return, but what is your expectation? I am just concern if your code matches your expectation or not.

you are right , i was expecting the function to return a number, didn't realise .toFixed() turned it in to a string

cjyuan · 2025-10-20T20:54:51Z

Sprint-2/5-stretch-extend/format-time.js

+  if(hours<1){
+    return `12:${minutes} am`
+  }
+  if(hours==12 && minutes==00){
+    return "12:00 pm"
+  }
  if (hours > 12) {
-    return `${hours - 12}:00 pm`;
+    return `${hours - 12}:${minutes} pm`;
  }
  return `${time} am`;
 }


Did your function return the values you expect from these function calls?

formatAs12HourClock("01:33");` formatAs12HourClock("13:33");

cjyuan · 2025-10-23T12:36:42Z

Sprint-2/5-stretch-extend/format-time.js

  const minutes=time.slice(3,5)
-  if(hours===0){
+  if(hours==0){
    return `12:${minutes} am`
  }
  if(hours===12 ){


Why change the === if one of the if statements, but not the other?

i shouldn't have changed it in the first place

…n time formatting

cjyuan · 2025-10-24T11:32:43Z

Well done.

alexandru-pocovnicu added 13 commits October 3, 2025 08:17

called a function , interpreted the error message

a318e04

fixed the code to log the function and not the parameter

686be02

fixed the function to return the square of a number by replacing the …

763574c

…parameter

replaced console.log with return inside the function

f7173fc

removed the semicolon after the "return" and moved "a+b" on the same …

9bfd01a

…line with"return" otherwise a semicolon would be automatically inserted

removed unused code and updated the parameter

58fda13

implemented a function that calculates bmi with one decimal

0b055f8

implemented a function that turns a string in to snake uppercase

b9c50c9

updated the function to replace all the spaces between words with"_"

e02e2e7

created a function that converts pence in to pounds

e9b8d94

added comments to answer the questions

57ad058

wrote test cases for edge cases and updated the function accordingly

c688a68

fix: add space for readability in time formatting condition

6aa1613

alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2025

cjyuan reviewed Oct 12, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 12, 2025

alexandru-pocovnicu added 2 commits October 20, 2025 21:15

style: format code for consistency and readability

ad3dfa9

refactor: simplify BMI calculation by removing unnecessary string con…

b2a5048

…version

alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 20, 2025

fix: correct time formatting logic for midnight and noon cases

b2684a1

cjyuan reviewed Oct 20, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 20, 2025

fix: update password validation logic

dab924b

alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 23, 2025

alexandru-pocovnicu mentioned this pull request Oct 23, 2025

ITP-2025-September | Structuring and testing data | Alexandru Pocovnicu. alexandru-pocovnicu/My-Coursework-Planner#60

Closed

cjyuan reviewed Oct 23, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 23, 2025

alexandru-pocovnicu added 2 commits October 24, 2025 10:38

fix: ensure BMI result is returned as a number

9c73a1c

fix: correct comparison operators and format output for consistency i…

03018e6

…n time formatting

alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 24, 2025

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 24, 2025

alexandru-pocovnicu mentioned this pull request Oct 30, 2025

ITP-2025-September | Structuring and Testing Data | Alexandru Pocovnicu alexandru-pocovnicu/My-Coursework-Planner#62

Open

Uh oh!

London | 25-ITP-May | Alexandru Pocovnicu | Sprint 2 | Acoursework #728

Are you sure you want to change the base?

London | 25-ITP-May | Alexandru Pocovnicu | Sprint 2 | Acoursework #728

Uh oh!

Conversation

alexandru-pocovnicu commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexandru-pocovnicu commented Oct 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alexandru-pocovnicu commented Oct 3, 2025 •

edited

Loading