zynthian_engine_jalv: Add controls for JV-880 #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Expression, Reverb and Chorus real-time controls for JV-880, in addition to the already existing Modulation Wheel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Expression, Reverb and Chorus real-time controls for JV-880, in addition to the already existing Modulation Wheel.
Reverb and Chorus are on/off parameters, but I don't know if zynthian_engine_jalv supports this, so they are displayed as ordinary (value range 0-127) continuous parameters.
JV-880 also supports portamento on/off (CC 65), pan (CC 10) and volume (CC 7), but I opted not to include them because pan and volume are normally controlled from the mixer view, and it's relatively unusual to use portamento, so I opted for a total of four parameters that can be shown on a single page.