Skip to content

compose: Add a controller.dispose call that we forgot #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

compose: Add a controller.dispose call that we forgot #1979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1619b0c
compose: Add a `controller.dispose` call that we forgot
chrisbobbe Nov 8, 2025
3ae958e
compose [nfc]: Put `_controller?.dispose` inside `_setNewController`
chrisbobbe Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/widgets/compose_box.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2091,7 +2091,6 @@ class _ComposeBoxState extends State<ComposeBox> with PerAccountStoreAwareStateM
// Fetch-raw-content failed; abort the edit session.
// An error dialog was already shown, by fetchRawContentWithFeedback.
setState(() {
controller.dispose();
_setNewController(PerAccountStoreWidget.of(context));
});
return;
Expand Down Expand Up @@ -2119,7 +2118,6 @@ class _ComposeBoxState extends State<ComposeBox> with PerAccountStoreAwareStateM

final store = PerAccountStoreWidget.of(context);
setState(() {
controller.dispose();
_setNewController(store);
});
}
Expand All @@ -2144,6 +2142,7 @@ class _ComposeBoxState extends State<ComposeBox> with PerAccountStoreAwareStateM
}

void _setNewController(PerAccountStore store) {
_controller?.dispose(); // `?.` because this might be the first call
switch (widget.narrow) {
case ChannelNarrow():
_controller = StreamComposeBoxController(store: store);
Expand Down