Log remote address on handshake errors #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something tries to speak HTTP or something to a ZMQ socket, chumak fills the logs with the
bad_greeting_frameerror which tells us what was transmitted, but not who transmitted it. Once more than a few possible machines are in the picture, it becomes very hard to figure out what is actually happening.This change uses
inet:peernameto get a human-readable remote IP address to be added to the logged error's metadata.