Skip to content

drivers: ethernet: lan9250: add support for a random mac address #99127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

drivers: ethernet: lan9250: add support for a random mac address #99127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b40fb04
drivers: ethernet: lan9250: add support for a random mac address
ckhardin Nov 8, 2025
1c940f7
drivers: ethernet: lan9250: add in the reset gpio configurate
ckhardin Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 48 additions & 6 deletions drivers/ethernet/eth_lan9250.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include <zephyr/net/net_pkt.h>
#include <zephyr/net/net_if.h>
#include <zephyr/net/ethernet.h>
#include <zephyr/random/random.h>
#include <ethernet/eth_stats.h>

#include "eth_lan9250_priv.h"
Expand Down Expand Up @@ -678,17 +679,48 @@ static int lan9250_init(const struct device *dev)
return -EINVAL;
}

if (gpio_pin_configure_dt(&config->interrupt, GPIO_INPUT)) {
ret = gpio_pin_configure_dt(&config->interrupt, GPIO_INPUT);
if (ret < 0) {
LOG_ERR("Unable to configure GPIO pin %u", config->interrupt.pin);
return -EINVAL;
return ret;
}

gpio_init_callback(&(context->gpio_cb), lan9250_gpio_callback, BIT(config->interrupt.pin));
if (gpio_add_callback(config->interrupt.port, &(context->gpio_cb))) {
return -EINVAL;
gpio_init_callback(&(context->gpio_cb), lan9250_gpio_callback,
BIT(config->interrupt.pin));
ret = gpio_add_callback(config->interrupt.port, &context->gpio_cb);
if (ret < 0) {
return ret;
}

gpio_pin_interrupt_configure_dt(&config->interrupt, GPIO_INT_EDGE_TO_ACTIVE);
ret = gpio_pin_interrupt_configure_dt(&config->interrupt,
GPIO_INT_EDGE_TO_ACTIVE);
if (ret < 0) {
LOG_ERR("Unable to enable GPIO INT %u", config->interrupt.pin);
return ret;
}

if (config->reset.port != NULL) {
if (!gpio_is_ready_dt(&config->reset)) {
LOG_ERR("GPIO port %s not ready", config->reset.port->name);
return -EINVAL;
}

ret = gpio_pin_configure_dt(&config->reset, GPIO_OUTPUT);
if (ret < 0) {
LOG_ERR("Unable to configure GPIO pin %u", config->reset.pin);
return ret;
}

/* See Section 19.6.3 from the LAN9250 Data Sheet
*
* trstia is 200 microseconds min (use 250 us)
* tcfg is 15 milliseconds min (use 20 ms for after reset)
*/
gpio_pin_set_dt(&config->reset, 1);
k_usleep(250);
gpio_pin_set_dt(&config->reset, 0);
k_msleep(20);
}

/* Reset and wait for ready on the LAN9250 SPI device */
ret = lan9250_sw_reset(dev);
Expand All @@ -697,6 +729,14 @@ static int lan9250_init(const struct device *dev)
return ret;
}
lan9250_configure(dev);

/* use a random MAC address if requested in the device tree */
if (config->random_mac) {
sys_rand_get(context->mac_address, sizeof(context->mac_address));
/* locally administered, unicast address */
context->mac_address[0] &= ~(BIT(0) | BIT(2) | BIT(3));
context->mac_address[0] |= BIT(1);
}
lan9250_set_macaddr(dev);

k_thread_create(&context->thread, context->thread_stack,
Expand All @@ -718,7 +758,9 @@ static int lan9250_init(const struct device *dev)
static const struct lan9250_config lan9250_##inst##_config = { \
.spi = SPI_DT_SPEC_INST_GET(inst, SPI_WORD_SET(8)), \
.interrupt = GPIO_DT_SPEC_INST_GET(inst, int_gpios), \
.reset = GPIO_DT_SPEC_INST_GET_OR(inst, reset_gpios, {0}), \
.timeout = CONFIG_ETH_LAN9250_BUF_ALLOC_TIMEOUT, \
.random_mac = DT_INST_PROP(inst, zephyr_random_mac_address), \
}; \
\
ETH_NET_DEVICE_DT_INST_DEFINE(inst, lan9250_init, NULL, &lan9250_##inst##_runtime, \
Expand Down
1 change: 1 addition & 0 deletions drivers/ethernet/eth_lan9250_priv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ struct lan9250_config {
struct gpio_dt_spec reset;
uint8_t full_duplex;
int32_t timeout;
bool random_mac;
};

struct lan9250_runtime {
Expand Down