-
Notifications
You must be signed in to change notification settings - Fork 8.2k
kernel: Add Kconfig option to disable LTO for kernel sources #99124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GTLin08
wants to merge
2
commits into
zephyrproject-rtos:main
Choose a base branch
from
GTLin08:it8xxx2_kernel_in_ram_lto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1138,6 +1138,28 @@ endif # BOOTARGS | |
|
|
||
| endmenu | ||
|
|
||
| config KERNEL_NO_LTO | ||
| bool "Build selected kernel core files without LTO" | ||
| depends on LTO | ||
| help | ||
| Some SoCs require kernel code to be placed in RAM, which makes link-time | ||
| optimization (LTO) unsuitable for these files (-fno-lto). Disabling LTO | ||
| allows the affected code to be linked as separate objects and placed in | ||
| specific memory regions. | ||
|
|
||
| Running kernel code from RAM can improve execution performance, especially | ||
| for timing-critical routines or context switch paths. | ||
|
|
||
| if KERNEL_NO_LTO | ||
| config KERNEL_LTO_ALLOWLIST | ||
| string "List of kernel source files to keep LTO" | ||
| help | ||
| List of kernel source filenames that should retain LTO even when | ||
| CONFIG_KERNEL_NO_LTO is enabled. | ||
| Example: CONFIG_KERNEL_LTO_ALLOWLIST="init.c errno.c fatal.c" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you want to make these files the default setting? Otherwise you could expand the help text to suggest this list as a good default as these features don't benefit from the performance gain of running in RAM. |
||
|
|
||
| endif # KERNEL_NO_LTO | ||
|
|
||
| rsource "Kconfig.device" | ||
| rsource "Kconfig.vm" | ||
| rsource "Kconfig.init" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # Optional script to disable LTO for kernel files | ||
|
|
||
| message(STATUS "[no-LTO] Building kernel files without LTO") | ||
|
|
||
| # Retrieve all source files from the kernel library target | ||
| if(TARGET kernel) | ||
| get_property(KERNEL_SRCS TARGET kernel PROPERTY SOURCES) | ||
| else() | ||
| message(WARNING "[no-LTO] kernel target not found, skipping") | ||
| return() | ||
| endif() | ||
|
|
||
| # Split allowlist string into list | ||
| if(DEFINED CONFIG_KERNEL_LTO_ALLOWLIST) | ||
| separate_arguments(LTO_ALLOWLIST NATIVE_COMMAND "${CONFIG_KERNEL_LTO_ALLOWLIST}") | ||
| endif() | ||
|
|
||
| # Apply -fno-lto to all C source files, except for some initialization files | ||
| # (e.g. init.c, errno.c, fatal.c) and those that are less critical to be | ||
| # placed in RAM. These files can be excluded from -fno-lto by using | ||
| # CONFIG_KERNEL_LTO_ALLOWLIST. | ||
| foreach(src ${KERNEL_SRCS}) | ||
| if(src MATCHES "\\.c$") | ||
|
|
||
| # Skip if filename matches any in allowlist | ||
| set(skip FALSE) | ||
| foreach(allow ${LTO_ALLOWLIST}) | ||
| get_filename_component(basename ${src} NAME) | ||
| if("${basename}" STREQUAL "${allow}") | ||
| set(skip TRUE) | ||
| break() | ||
| endif() | ||
| endforeach() | ||
|
|
||
| if(NOT skip) | ||
| set_source_files_properties(${src} PROPERTIES COMPILE_FLAGS "-fno-lto -g") | ||
| endif() | ||
|
|
||
| endif() | ||
| endforeach() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.