net: lwm2m: Fix SenML CBOR resource instance encoding #99121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consecutive resource instance name should be encoded regardless of whether timestamp is present or not. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
1 task
Contributor
Author
|
FYI @walzsi, please see the linked issue. I wanted to avoid reverting your changes, I think the proposed fix should work fine with timestamped resource instances as well, at least your tests pass. |
|
Contributor
Looks good, maybe the case with multiple resource instances should also be included into the testcase. |
jukkar
approved these changes
Nov 11, 2025
SeppoTakalo
approved these changes
Nov 12, 2025
jhedberg
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consecutive resource instance name should be encoded regardless of whether timestamp is present or not.
Fixes #99088