Skip to content

Fix weave import side-effects when enable_weave=False #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
+0 −9
Merged

Fix weave import side-effects when enable_weave=False #4265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/zenml/integrations/wandb/experiment_trackers/wandb_experiment_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,3 @@ def _initialize_wandb(
"Weave enabled but no project_name specified. "
"Skipping weave initialization."
)
else:
import weave

if self.config.project_name:
logger.info("Disabling weave")
weave.init(
Copy link
Contributor

@bcdurak bcdurak Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what this implies, if the issue is to import it, perhaps we can cover it in a try-except. Basically, you can still try to disable it if weave is installed?

Copy link
Contributor Author

@strickvl strickvl Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah Hamza also couldn't remember what it implied @bcdurak but I tested it 🤷

Copy link
Contributor

@bcdurak bcdurak Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I saw the discussion above. He mentioned that he implemented this for a reason. That's exactly why I still think that it would be safer to just wrap this in a try-except, but I will leave it up to you.

Copy link
Contributor

@htahir1 htahir1 Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its fine lets merge it

Copy link
Contributor

@bcdurak bcdurak Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htahir1 it is already merged.

Copy link
Contributor

@bcdurak bcdurak Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just a late comment here.

project_name=self.config.project_name,
settings={"disabled": True},
)
Loading