-
Notifications
You must be signed in to change notification settings - Fork 559
Improve CLI Tables and IDs handling #4241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add missing parameter documentation and return values for CLI display functions to resolve CI docstring validation errors. This includes fixes for service connectors, table utilities, tags, pipelines, stack components, models, artifacts, authorized devices, secrets, and service accounts. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Complete the docstring fixes for artifact versions and ensure all critical CLI table functions have proper parameter and return documentation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add missing Args and Returns sections to functions in model.py - Fix docstring issues in stack_components.py flavor functions - Add parameter documentation to code_repository.py - Fix utils.py print_page_info docstring - Complete user_management.py docstring documentation - Add missing documentation to project.py functions All darglint docstring validation errors are now resolved for CLI files. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix Page[T] vs List[Any] type mismatches in prepare_list_data calls - Add type ignore comments for model_dump no-any-return issues - Fix missing type annotations in user_management.py - Handle object vs List[Any] issues with proper type ignore comments - Ensure proper handling of paginated vs non-paginated responses Resolves all remaining mypy errors that were causing CI failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix line formatting in project.py, service_accounts.py, tag.py, user_management.py - Ensure consistent formatting across all modified CLI files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…-io/zenml into feature/improve-cli-tables
…-io/zenml into feature/improve-cli-tables
schustmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run e.g. zenml stack list -o json > stacks.json, this doesn't produce a valid JSON file yet.
|
@schustmi issue was with added syntax_highlight function, it should be fixed now |
bcdurak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit tight on time so I was not able to review the utils in much detail. I left some comments again.
Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>
Describe changes
This PR refactors the ZenML CLI table rendering system to:
Key technical changes:
zenml_climodule for stdout/stderr routingrender_list_output(),handle_output(),prepare_output()list_optionsdecorator with auto-rendering supportPre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes