rake

Author: cryptomail

lib/zendesk_api/resources.rb

@@ -473,25 +473,25 @@ def initialize(ticket)
 
       def [](key)
         raise "Cannot find custom field #{key}, configuration ticket_fields_metadata is OFF" unless
-          @ticket.instance_variable_get("@client").ticket_fields_metadata
+          @ticket.instance_variable_get(:@client).ticket_fields_metadata
         # Trap read access
-        fld = @ticket.instance_variable_get("@client").ticket_fields_metadata.find { |val| val[:title] == key }
+        fld = @ticket.instance_variable_get(:@client).ticket_fields_metadata.find { |val| val[:title] == key }
         raise "Cannot find custom field #{key}" unless fld
         cf = @ticket.custom_fields.find { |h| h[:id] == fld[:id] }
         cf ? cf[:value] : nil
       end
 
       def []=(key, value)
         raise "Cannot find custom field #{key}, configuration ticket_fields_metadata is OFF" unless
-          @ticket.instance_variable_get("@client").ticket_fields_metadata
+          @ticket.instance_variable_get(:@client).ticket_fields_metadata
         # Trap write access
-        fld = @ticket.instance_variable_get("@client").ticket_fields_metadata.find { |val| val[:title] == key }
+        fld = @ticket.instance_variable_get(:@client).ticket_fields_metadata.find { |val| val[:title] == key }
         raise "Cannot find custom field #{key}" unless fld
         cf = @ticket.custom_fields.find { |h| h[:id] == fld[:id] } if @ticket.custom_fields
         if cf
           cf[:value] = value
         else
-          @ticket.custom_fields << { id: fld[:id], value: value }
+          @ticket.custom_fields << {id: fld[:id], value: value}
         end
       end
 

spec/core/resources/custom_field_symbol_proxy_spec.rb

@@ -1,11 +1,11 @@
-require 'core/spec_helper'
-require_relative '../../../lib/zendesk_api/resources'
+require "core/spec_helper"
+require_relative "../../../lib/zendesk_api/resources"
 
 RSpec.describe ZendeskAPI::Ticket::CustomFieldSymbolProxy do
   let(:field_metadata) do
     [
-      { id: 1, title: "foo" },
-      { id: 2, title: "bar" }
+      {id: 1, title: "foo"},
+      {id: 2, title: "bar"}
     ]
   end
   let(:client) do
@@ -16,7 +16,7 @@
   let(:ticket) do
     t = ZendeskAPI::Ticket.new({})
     t.instance_variable_set(:@client, client)
-    t.instance_variable_set(:@custom_fields, [{ id: 1, value: "abc" }])
+    t.instance_variable_set(:@custom_fields, [{id: 1, value: "abc"}])
     def t.custom_fields
       _foo = 1
       @custom_fields
@@ -31,7 +31,7 @@ def t.custom_fields
     end
 
     it "returns nil for existing field with no value" do
-      ticket.instance_variable_set(:@custom_fields, [{ id: 1 }])
+      ticket.instance_variable_set(:@custom_fields, [{id: 1}])
       expect(proxy["foo"]).to be_nil
     end
 
@@ -63,14 +63,13 @@ def t.custom_fields
     it "returns proxy from custom_field_symbol accessor" do
       t = ZendeskAPI::Ticket.new({})
       t.instance_variable_set(:@client, client)
-      t.instance_variable_set(:@custom_fields, [{ id: 1, value: "abc" }])
+      t.instance_variable_set(:@custom_fields, [{id: 1, value: "abc"}])
       def t.custom_fields
         _foo = 1
         @custom_fields
       end
       expect(t.custom_field_symbol["foo"]).to eq("abc")
     end
-
   end
 
   describe "[] and []= with missing ticket_fields_metadata" do

spec/live/ticket_spec.rb

@@ -213,17 +213,17 @@ def valid_attributes
   describe "CustomFieldSymbolProxy" do
     let(:field_metadata) do
       [
-        { id: 1, title: "foo" },
-        { id: 2, title: "bar" }
+        {id: 1, title: "foo"},
+        {id: 2, title: "bar"}
       ]
     end
     let(:client) do
-      double("Client", :instance_variable_get => field_metadata)
+      double("Client", instance_variable_get: field_metadata)
     end
     let(:ticket) do
       t = ZendeskAPI::Ticket.allocate
       t.instance_variable_set(:@client, client)
-      t.instance_variable_set(:@custom_fields, [{ id: 1, value: "abc" }])
+      t.instance_variable_set(:@custom_fields, [{id: 1, value: "abc"}])
       t
     end
     let(:proxy) { ZendeskAPI::Ticket::CustomFieldSymbolProxy.new(ticket, nil) }
@@ -254,10 +254,9 @@ def valid_attributes
       it "returns proxy from custom_field_symbol accessor" do
         t = ZendeskAPI::Ticket.allocate
         t.instance_variable_set(:@client, client)
-        t.instance_variable_set(:@custom_fields, [{ id: 1, value: "abc" }])
+        t.instance_variable_set(:@custom_fields, [{id: 1, value: "abc"}])
         expect(t.custom_field_symbol["foo"]).to eq("abc")
       end
-
     end
   end
 end