removed some fairly silly things. Setting the proxy is not a supported activity by any stretch of the imagination

Author: cryptomail

lib/zendesk_api/resources.rb

@@ -466,7 +466,7 @@ class Ticket < Resource
 
     # Proxy to trap array operator usage on custom_field_symbol
     class CustomFieldSymbolProxy
-      def initialize(ticket, _arr)
+      def initialize(ticket)
         @ticket = ticket
         @field_array = @ticket.custom_fields || []
       end
@@ -510,12 +510,7 @@ def respond_to_missing?(method, include_private = false)
     end
 
     def custom_field_symbol
-      @custom_field_symbol ||= CustomFieldSymbolProxy.new(self, @custom_field_symbol)
-    end
-
-    def custom_field_symbol=(val)
-      @custom_field_symbol = val
-      @custom_field_symbol_proxy = CustomFieldSymbolProxy.new(self, @custom_field_symbol)
+      @custom_field_symbol_proxy ||= CustomFieldSymbolProxy.new(self)
     end
 
     def self.cbp_path_regexes

spec/core/resources/custom_field_symbol_proxy_spec.rb

@@ -23,7 +23,7 @@ def t.custom_fields
     end
     t
   end
-  let(:proxy) { described_class.new(ticket, nil) }
+  let(:proxy) { described_class.new(ticket) }
 
   describe "[] and []=" do
     it "reads a custom field by symbol (existing)" do
@@ -71,16 +71,6 @@ def t.custom_fields
       expect(t.custom_field_symbol["foo"]).to eq("abc")
     end
 
-    it "updates proxy on custom_field_symbol= assignment" do
-      t = ZendeskAPI::Ticket.new({})
-      t.instance_variable_set(:@client, client)
-      def t.custom_fields
-        _foo = 1
-        @custom_fields
-      end
-      t.custom_field_symbol = [{ id: 1, value: "xyz" }]
-      expect(t.custom_field_symbol.to_a).to eq([{ id: 1, value: "xyz" }])
-    end
   end
 
   describe "[] and []= with missing ticket_fields_metadata" do

spec/live/ticket_spec.rb

@@ -258,12 +258,6 @@ def valid_attributes
         expect(t.custom_field_symbol["foo"]).to eq("abc")
       end
 
-      it "updates proxy on custom_field_symbol= assignment" do
-        t = ZendeskAPI::Ticket.allocate
-        t.instance_variable_set(:@client, client)
-        t.custom_field_symbol = [{ id: 1, value: "xyz" }]
-        expect(t.custom_field_symbol.to_a).to eq([{ id: 1, value: "xyz" }])
-      end
     end
   end
 end