Skip to content

Conversation

@ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Nov 6, 2025

closes #3568

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.90%. Comparing base (d0c3b7f) to head (d72419f).

Files with missing lines Patch % Lines
src/zarr/core/chunk_grids.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3574      +/-   ##
==========================================
+ Coverage   61.87%   61.90%   +0.03%     
==========================================
  Files          85       85              
  Lines       10134    10147      +13     
==========================================
+ Hits         6270     6282      +12     
- Misses       3864     3865       +1     
Files with missing lines Coverage Δ
src/zarr/core/config.py 38.88% <ø> (ø)
src/zarr/core/chunk_grids.py 63.33% <86.66%> (+3.52%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Nov 6, 2025
@ilan-gold ilan-gold marked this pull request as ready for review November 6, 2025 13:42
@ilan-gold
Copy link
Contributor Author

Not sure I fully grasp what is going on with codecov, it looks like the tests run and assert the things they should and use the funcionality promised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make auto sharding configurable by memory size

1 participant